Removing calls to some deprecated Sinon APIs (#233)

Author: hiranya911

package-lock.json

@@ -96,7 +96,7 @@
     "request-promise": "^4.1.1",
     "run-sequence": "^1.1.5",
     "scrypt": "^6.0.3",
-    "sinon": "^4.3.0",
+    "sinon": "^4.4.5",
     "sinon-chai": "^2.8.0",
     "ts-node": "^3.3.0",
     "tslint": "^5.9.0",

package.json

@@ -92,7 +92,7 @@ describe('FirebaseApp', () => {
       delete process.env[FIREBASE_CONFIG_VAR];
     }
 
-    deleteSpy.reset();
+    deleteSpy.resetHistory();
     (firebaseNamespaceInternals.removeApp as any).restore();
 
     _.forEach(mockedRequests, (mockedRequest) => mockedRequest.done());
@@ -907,7 +907,7 @@ describe('FirebaseApp', () => {
     });
 
     afterEach(() => {
-      addAuthTokenListenerSpy.reset();
+      addAuthTokenListenerSpy.resetHistory();
     });
 
     it('is notified when the token changes', () => {
@@ -964,7 +964,7 @@ describe('FirebaseApp', () => {
     });
 
     afterEach(() => {
-      addAuthTokenListenerSpies.forEach((spy) => spy.reset());
+      addAuthTokenListenerSpies.forEach((spy) => spy.resetHistory());
     });
 
     it('removes the listener', () => {

test/unit/firebase-app.spec.ts

@@ -309,7 +309,7 @@ describe('FirebaseNamespace', () => {
 
       const app = firebaseNamespace.initializeApp(mocks.appOptions, mocks.appName);
 
-      appHook.reset();
+      appHook.resetHistory();
 
       firebaseNamespace.INTERNAL.removeApp(mocks.appName);