Skip to content

Commit 681d353

Browse files
author
Pijush Chakraborty
committed
Removing parameter groups
1 parent 20749d7 commit 681d353

File tree

2 files changed

+1
-17
lines changed

2 files changed

+1
-17
lines changed

firebase_admin/remote_config.py

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -56,14 +56,6 @@ def __init__(self, etag, template_data):
5656
if 'version' in template_data:
5757
self._version = template_data['version']
5858

59-
if 'parameterGroups' in template_data:
60-
if template_data['parameterGroups'] is not None:
61-
self._parameter_groups = template_data['parameterGroups']
62-
else:
63-
raise ValueError('Remote Config parameterGroups must be a non-null object')
64-
else:
65-
self.parameter_groups = {}
66-
6759
self._etag = ''
6860
if etag is not None and isinstance(etag, str):
6961
self._etag = etag
@@ -84,10 +76,6 @@ def version(self):
8476
def conditions(self):
8577
return self._conditions
8678

87-
@property
88-
def parameter_groups(self):
89-
return self._parameter_groups
90-
9179

9280
class ServerTemplate:
9381
"""Represents a Server Template with implementations for loading and evaluting the tempalte."""

tests/test_remote_config.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,6 @@ def test_rc_instance_get_server_template(self):
5555
'test_key': 'test_value'
5656
},
5757
'conditions': [],
58-
'parameterGroups': {},
5958
'version': 'test'
6059
})
6160

@@ -75,7 +74,6 @@ def test_rc_instance_get_server_template_empty_params(self):
7574
recorder = []
7675
response = json.dumps({
7776
'conditions': [],
78-
'parameterGroups': {},
7977
'version': 'test'
8078
})
8179

@@ -109,13 +107,12 @@ def test_init_server_template(self):
109107
'parameters': {
110108
'test_key': 'test_value'
111109
},
112-
'parameterGroups': '',
113110
'version': '',
114111
}
115112

116113
template = remote_config.init_server_template(
117114
app=app,
118-
template_data=ServerTemplateData('etag', template_data) # Use ServerTemplateData here
115+
template_data=ServerTemplateData('etag', template_data)
119116
)
120117

121118
config = template.evaluate()
@@ -133,7 +130,6 @@ async def test_get_server_template(self):
133130
'test_key': 'test_value'
134131
},
135132
'conditions': [],
136-
'parameterGroups': {},
137133
'version': 'test'
138134
})
139135

0 commit comments

Comments
 (0)