Skip to content

Commit 0246254

Browse files
committed
As reported in #7340, RemoteConfig interactions are removed from AppStartTrace (RemoteConfig is no longer supported, thus is safe to delete).
1 parent e25e52c commit 0246254

File tree

1 file changed

+8
-21
lines changed

1 file changed

+8
-21
lines changed

firebase-perf/src/main/java/com/google/firebase/perf/config/ConfigResolver.java

Lines changed: 8 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -820,35 +820,22 @@ public double getFragmentSamplingRate() {
820820
return config.getDefault();
821821
}
822822

823-
/** Returns if _experiment_app_start_ttid should be captured. */
823+
/**
824+
* Returns if _experiment_app_start_ttid should be captured. This experiment is disabled.
825+
* Therefore, interactions with Remote Config and the cached layer are no longer necessary,
826+
* preventing unnecessary StrictMode DiskReadViolation penalties.
827+
* {@see https://github.com/firebase/firebase-android-sdk/issues/7340}
828+
*/
824829
public boolean getIsExperimentTTIDEnabled() {
825-
// Order of precedence is:
826-
// 1. If the value exists in Android Manifest, return this value.
827-
// 2. If the value exists through Firebase Remote Config, cache and return this value.
828-
// 3. If the value exists in device cache, return this value.
829-
// 4. Otherwise, return default value.
830830
ExperimentTTID config = ExperimentTTID.getInstance();
831831

832-
// 1. Reads value in Android Manifest (it is set by developers during build time).
832+
// Reads value in Android Manifest (it is set by developers during build time).
833833
Optional<Boolean> metadataValue = getMetadataBoolean(config);
834834
if (metadataValue.isAvailable()) {
835835
return metadataValue.get();
836836
}
837837

838-
// 2. Reads value from Firebase Remote Config, saves this value in cache layer if valid.
839-
Optional<Boolean> rcValue = getRemoteConfigBoolean(config);
840-
if (rcValue.isAvailable()) {
841-
deviceCacheManager.setValue(config.getDeviceCacheFlag(), rcValue.get());
842-
return rcValue.get();
843-
}
844-
845-
// 3. Reads value from cache layer.
846-
Optional<Boolean> deviceCacheValue = getDeviceCacheBoolean(config);
847-
if (deviceCacheValue.isAvailable()) {
848-
return deviceCacheValue.get();
849-
}
850-
851-
// 4. Returns default value if there is no valid value from above approaches.
838+
// Returns default value if there is no valid value from above approaches.
852839
return config.getDefault();
853840
}
854841

0 commit comments

Comments
 (0)