dataconnect: tests: fix unparseableDash() in LocalDateSerializerUnitTest.kt et al (#7155)

dconeybe · web-flow · commit 16f1d99b4a6e · 2025-07-16T16:21:13.000-04:00
diff --git a/firebase-dataconnect/src/test/kotlin/com/google/firebase/dataconnect/serializers/JavaTimeLocalDateSerializerUnitTest.kt b/firebase-dataconnect/src/test/kotlin/com/google/firebase/dataconnect/serializers/JavaTimeLocalDateSerializerUnitTest.kt
@@ -222,7 +222,8 @@ class JavaTimeLocalDateSerializerUnitTest {
     }
 
     fun Arb.Companion.unparseableDash(): Arb<String> {
-      val invalidString = string(1..5, codepoints.filterNot { it.value == '-'.code })
+      val invalidString =
+        string(1..5, codepoints.filterNot { it.value == '-'.code || Character.isDigit(it.value) })
       return arbitrary { rs ->
         val flags = Array(3) { rs.random.nextBoolean() }
         if (!flags[0]) {
diff --git a/firebase-dataconnect/src/test/kotlin/com/google/firebase/dataconnect/serializers/KotlinxDatetimeLocalDateSerializerUnitTest.kt b/firebase-dataconnect/src/test/kotlin/com/google/firebase/dataconnect/serializers/KotlinxDatetimeLocalDateSerializerUnitTest.kt
@@ -225,7 +225,8 @@ class KotlinxDatetimeLocalDateSerializerUnitTest {
     }
 
     fun Arb.Companion.unparseableDash(): Arb<String> {
-      val invalidString = string(1..5, codepoints.filterNot { it.value == '-'.code })
+      val invalidString =
+        string(1..5, codepoints.filterNot { it.value == '-'.code || Character.isDigit(it.value) })
       return arbitrary { rs ->
         val flags = Array(3) { rs.random.nextBoolean() }
         if (!flags[0]) {
diff --git a/firebase-dataconnect/src/test/kotlin/com/google/firebase/dataconnect/serializers/LocalDateSerializerUnitTest.kt b/firebase-dataconnect/src/test/kotlin/com/google/firebase/dataconnect/serializers/LocalDateSerializerUnitTest.kt
@@ -206,10 +206,7 @@ class LocalDateSerializerUnitTest {
 
     fun Arb.Companion.unparseableDash(): Arb<String> {
       val invalidString =
-        string(
-          1..5,
-          codepoints.filterNot { it.value == '-'.code || it.value in '0'.code..'9'.code }
-        )
+        string(1..5, codepoints.filterNot { it.value == '-'.code || Character.isDigit(it.value) })
       return arbitrary { rs ->
         val flags = Array(3) { rs.random.nextBoolean() }
         if (!flags[0]) {

Original file line number	Diff line number	Diff line change
`@@ -222,7 +222,8 @@ class JavaTimeLocalDateSerializerUnitTest {`
`222`	`222`	`}`
`223`	`223`
`224`	`224`	`fun Arb.Companion.unparseableDash(): Arb<String> {`
`225`		`- val invalidString = string(1..5, codepoints.filterNot { it.value == '-'.code })`
	`225`	`+ val invalidString =`
	`226`	`+ string(1..5, codepoints.filterNot { it.value == '-'.code \|\| Character.isDigit(it.value) })`
`226`	`227`	`return arbitrary { rs ->`
`227`	`228`	`val flags = Array(3) { rs.random.nextBoolean() }`
`228`	`229`	`if (!flags[0]) {`
Original file line number	Diff line number	Diff line change
`@@ -225,7 +225,8 @@ class KotlinxDatetimeLocalDateSerializerUnitTest {`
`225`	`225`	`}`
`226`	`226`
`227`	`227`	`fun Arb.Companion.unparseableDash(): Arb<String> {`
`228`		`- val invalidString = string(1..5, codepoints.filterNot { it.value == '-'.code })`
	`228`	`+ val invalidString =`
	`229`	`+ string(1..5, codepoints.filterNot { it.value == '-'.code \|\| Character.isDigit(it.value) })`
`229`	`230`	`return arbitrary { rs ->`
`230`	`231`	`val flags = Array(3) { rs.random.nextBoolean() }`
`231`	`232`	`if (!flags[0]) {`