Skip to content

Commit 18465b6

Browse files
committed
Reduce dagger version bump
Dagger versions above 2.51 cause a very weird error in which a constant in the FeedbackSender code in appdistribution will end up mangled and cause the tests to fail "ONLY IN RELEASE TESTS". The FILE_EXTENSION_JPG = .jpg gets tur into change FILE_EXTENSION_JPG = com.google.firebase.appdistribution.impl.jpg causing the extension check to fail
1 parent 5a09fc8 commit 18465b6

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

firebase-appdistribution/src/main/java/com/google/firebase/appdistribution/impl/FeedbackSender.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,9 @@ class FeedbackSender {
3333
static final String CONTENT_TYPE_PNG = "image/png";
3434

3535
private static final String TAG = "FeedbackSender";
36-
private static final String FILE_EXTENSION_JPG = "jpg";
37-
private static final String FILE_EXTENSION_JPEG = "jpeg";
38-
private static final String FILE_EXTENSION_PNG = "png";
36+
private static final String FILE_EXTENSION_JPG = ".jpg";
37+
private static final String FILE_EXTENSION_JPEG = ".jpeg";
38+
private static final String FILE_EXTENSION_PNG = ".png";
3939
private static final String DEFAULT_FILENAME = "screenshot.png";
4040

4141
private final ContentResolver contentResolver;

gradle/libs.versions.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ checkerQual = "2.5.2"
1818
constraintlayout = "2.1.4"
1919
coreKtx = "1.12.0"
2020
coroutines = "1.9.0"
21-
dagger = "2.55"
21+
dagger = "2.51" # Don't bump above 2.51 as it causes a bug in AppDistro FeedbackSender JPEG code
2222
datastore = "1.1.3"
2323
dexmaker = "2.28.1"
2424
dexmakerVersion = "1.2"

0 commit comments

Comments
 (0)