Use helper method to make code more DRY

tom-andersen · tom-andersen · commit 22f33d7cfacb · 2025-06-12T11:23:12.000-04:00
diff --git a/firebase-firestore/src/main/java/com/google/firebase/firestore/model/ObjectValue.java b/firebase-firestore/src/main/java/com/google/firebase/firestore/model/ObjectValue.java
@@ -42,8 +42,7 @@ public final class ObjectValue implements Cloneable {
   private final Map<String, Object> overlayMap = new HashMap<>();
 
   public static ObjectValue fromMap(Map<String, Value> value) {
-    return new ObjectValue(
-        Value.newBuilder().setMapValue(MapValue.newBuilder().putAllFields(value)).build());
+    return new ObjectValue(Values.encodeValue(value));
   }
 
   public ObjectValue(Value value) {

Original file line number	Diff line number	Diff line change
`@@ -42,8 +42,7 @@ public final class ObjectValue implements Cloneable {`
`42`	`42`	`private final Map<String, Object> overlayMap = new HashMap<>();`
`43`	`43`
`44`	`44`	`public static ObjectValue fromMap(Map<String, Value> value) {`
`45`		`- return new ObjectValue(`
`46`		`- Value.newBuilder().setMapValue(MapValue.newBuilder().putAllFields(value)).build());`
	`45`	`+ return new ObjectValue(Values.encodeValue(value));`
`47`	`46`	`}`
`48`	`47`
`49`	`48`	`public ObjectValue(Value value) {`