dataconnect: shellcheck all bash shell scripts

Author: dconeybe

.github/workflows/dataconnect.yml

@@ -271,6 +271,17 @@ jobs:
         with:
           args: -color /github/workspace/.github/workflows/dataconnect.yml
 
+  shellcheck:
+    continue-on-error: false
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+        with:
+          show-progress: false
+          sparse-checkout: 'firebase-dataconnect/'
+      - name: shellcheck
+        run: find . -name '*.sh' -print0 | xargs --verbose -0 shellcheck --norc --enable=all --shell=bash
+
   python-ci-unit-tests:
     continue-on-error: false
     runs-on: ubuntu-latest

firebase-dataconnect/emulator/emulator.sh

@@ -16,7 +16,8 @@
 
 set -euo pipefail
 
-readonly SCRIPT_DIR="$(dirname "$0")"
+SCRIPT_DIR="$(dirname "$0")"
+readonly SCRIPT_DIR
 readonly SELF_EXECUTABLE="$0"
 readonly LOG_PREFIX="[$0] "
 readonly DEFAULT_POSTGRESQL_STRING='postgresql://postgres:postgres@localhost:5432?sslmode=disable'
@@ -38,7 +39,7 @@ function parse_args {
   local OPTIND=1
   local OPTERR=0
   while getopts ":c:p:v:hw" arg ; do
-    case "$arg" in
+    case "${arg}" in
       c) emulator_binary="${OPTARG}" ;;
       p) postgresql_string="${OPTARG}" ;;
       v) preview_flags="${OPTARG}" ;;
@@ -58,7 +59,7 @@ function parse_args {
         exit 2
         ;;
       *)
-        echo "INTERNAL ERROR: unknown argument: $arg" >&2
+        echo "INTERNAL ERROR: unknown argument: ${arg}" >&2
         exit 1
         ;;
     esac
@@ -68,7 +69,7 @@ function parse_args {
   export FIREBASE_DATACONNECT_POSTGRESQL_STRING="${postgresql_string}"
   export DATA_CONNECT_PREVIEW="${preview_flags}"
 
-  if [[ $wipe_and_restart_postgres_pod == "1" ]] ; then
+  if [[ ${wipe_and_restart_postgres_pod} == "1" ]] ; then
     run_command "${SCRIPT_DIR}/wipe_postgres_db.sh"
     run_command "${SCRIPT_DIR}/start_postgres_pod.sh"
   fi

firebase-dataconnect/emulator/start_postgres_pod.sh

@@ -25,8 +25,9 @@ function run_command {
   "$@"
 }
 
-# Determine the absolute path of the directory containing this file.
-readonly SCRIPT_DIR="$(readlink -f $(dirname "$0"))"
+# Determine the path of the directory containing this file.
+SCRIPT_DIR="$(dirname "$0")"
+readonly SCRIPT_DIR
 
 # Create the podman "pod" if it is not already created.
 # Bind the PostgreSQL server to port 5432 on the host, so that the host can connect to it.

firebase-dataconnect/scripts/compile_kotlin.sh

@@ -16,7 +16,8 @@
 
 set -euo pipefail
 
-readonly PROJECT_ROOT_DIR="$(dirname "$0")/../.."
+PROJECT_ROOT_DIR="$(dirname "$0")/../.."
+readonly PROJECT_ROOT_DIR
 
 readonly TARGETS=(
   ":firebase-dataconnect:compileDebugKotlin"

firebase-dataconnect/scripts/emulator_run.sh

@@ -16,7 +16,8 @@
 
 set -euo pipefail
 
-readonly PROJECT_ROOT_DIR="$(dirname "$0")/../.."
+PROJECT_ROOT_DIR="$(dirname "$0")/../.."
+readonly PROJECT_ROOT_DIR
 
 (
   set -xv

firebase-dataconnect/scripts/generateApiTxtFile.sh

@@ -16,7 +16,8 @@
 
 set -euo pipefail
 
-readonly PROJECT_ROOT_DIR="$(dirname "$0")/../.."
+PROJECT_ROOT_DIR="$(dirname "$0")/../.."
+readonly PROJECT_ROOT_DIR
 
 readonly args=(
   "${PROJECT_ROOT_DIR}/gradlew"

firebase-dataconnect/scripts/generate_data_connect_sources.sh

@@ -16,7 +16,8 @@
 
 set -euo pipefail
 
-readonly PROJECT_ROOT_DIR="$(dirname "$0")/../.."
+PROJECT_ROOT_DIR="$(dirname "$0")/../.."
+readonly PROJECT_ROOT_DIR
 
 readonly TARGETS=(
   ":firebase-dataconnect:connectors:generateDebugDataConnectSources"

firebase-dataconnect/scripts/run_all_tests.sh

@@ -16,7 +16,8 @@
 
 set -euo pipefail
 
-readonly PROJECT_ROOT_DIR="$(dirname "$0")/../.."
+PROJECT_ROOT_DIR="$(dirname "$0")/../.."
+readonly PROJECT_ROOT_DIR
 
 readonly TARGETS=(
   ":firebase-dataconnect:androidTestutil:connectedDebugAndroidTest"

firebase-dataconnect/scripts/run_integration_tests.sh

@@ -16,7 +16,8 @@
 
 set -euo pipefail
 
-readonly PROJECT_ROOT_DIR="$(dirname "$0")/../.."
+PROJECT_ROOT_DIR="$(dirname "$0")/../.."
+readonly PROJECT_ROOT_DIR
 
 readonly TARGETS=(
   ":firebase-dataconnect:connectedDebugAndroidTest"

firebase-dataconnect/scripts/run_unit_tests.sh

@@ -16,7 +16,8 @@
 
 set -euo pipefail
 
-readonly PROJECT_ROOT_DIR="$(dirname "$0")/../.."
+PROJECT_ROOT_DIR="$(dirname "$0")/../.."
+readonly PROJECT_ROOT_DIR
 
 readonly TARGETS=(
   ":firebase-dataconnect:testDebugUnitTest"