Try simplifying logging

Author: tejasd

firebase-perf/src/main/java/com/google/firebase/perf/logging/DebugEnforcementCheck.kt

@@ -25,11 +25,18 @@ class DebugEnforcementCheck {
     @JvmStatic var enforcement: Boolean = false
     private var logger: AndroidLogger = AndroidLogger.getInstance()
 
-    public fun checkSession(session: PerfSession, failureMessage: String) {
+    fun checkSession(session: PerfSession, failureMessage: String) {
       if (session.isLegacy()) {
         logger.debug("legacy session ${session.sessionId()}: $failureMessage")
         assert(!enforcement) { failureMessage }
       }
     }
+
+    fun checkSession(sessionId: String, failureMessage: String) {
+      if (sessionId.isLegacy()) {
+        logger.debug("legacy session ${sessionId}: $failureMessage")
+        assert(!enforcement) { failureMessage }
+      }
+    }
   }
 }

firebase-perf/src/main/java/com/google/firebase/perf/session/FirebaseSessionsHelper.kt

@@ -5,7 +5,12 @@ import java.util.UUID
 
 /** Identifies whether the [PerfSession] is legacy or not. */
 fun PerfSession.isLegacy(): Boolean {
-  return this.sessionId().startsWith(Constants.UNDEFINED_AQS_ID_PREFIX)
+  return this.sessionId().isLegacy()
+}
+
+/** Identifies whether the string is from a legacy [PerfSession]. */
+fun String.isLegacy(): Boolean {
+  return this.startsWith(Constants.UNDEFINED_AQS_ID_PREFIX)
 }
 
 /** Creates a valid session ID for [PerfSession] that can be predictably identified as legacy. */

firebase-perf/src/main/java/com/google/firebase/perf/session/gauges/GaugeManager.java

@@ -22,6 +22,7 @@
 import com.google.firebase.components.Lazy;
 import com.google.firebase.perf.config.ConfigResolver;
 import com.google.firebase.perf.logging.AndroidLogger;
+import com.google.firebase.perf.logging.DebugEnforcementCheck;
 import com.google.firebase.perf.session.FirebaseSessionsHelperKt;
 import com.google.firebase.perf.session.PerfSession;
 import com.google.firebase.perf.transport.TransportManager;
@@ -287,10 +288,7 @@ public void stopCollectingGaugesForLegacySession(
    * @param appState The app state for which these gauges are collected.
    */
   private void syncFlush(String sessionId, ApplicationProcessState appState) {
-    if (sessionId.contains(Constants.UNDEFINED_AQS_ID_PREFIX)) {
-      // TODO(b/394127311): Use DebugEnforcementCheck.
-      logger.debug("Flushing gauge metrics to a legacy session ID.");
-    }
+    DebugEnforcementCheck.Companion.checkSession(sessionId, "syncFlush");
     GaugeMetric.Builder gaugeMetricBuilder = GaugeMetric.newBuilder();
 
     // Adding CPU metric readings.