Skip to content

Commit 2d1905e

Browse files
authored
Make token count details fields non-nullable (#6695)
If missing, they'll default to empty.
1 parent f6b59f6 commit 2d1905e

File tree

4 files changed

+16
-14
lines changed

4 files changed

+16
-14
lines changed

firebase-vertexai/api.txt

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -183,14 +183,14 @@ package com.google.firebase.vertexai.type {
183183
}
184184

185185
public final class CountTokensResponse {
186-
ctor public CountTokensResponse(int totalTokens, Integer? totalBillableCharacters = null, java.util.List<com.google.firebase.vertexai.type.ModalityTokenCount>? promptTokensDetails = null);
186+
ctor public CountTokensResponse(int totalTokens, Integer? totalBillableCharacters = null, java.util.List<com.google.firebase.vertexai.type.ModalityTokenCount> promptTokensDetails = emptyList());
187187
method public operator int component1();
188188
method public operator Integer? component2();
189189
method public operator java.util.List<com.google.firebase.vertexai.type.ModalityTokenCount>? component3();
190-
method public java.util.List<com.google.firebase.vertexai.type.ModalityTokenCount>? getPromptTokensDetails();
190+
method public java.util.List<com.google.firebase.vertexai.type.ModalityTokenCount> getPromptTokensDetails();
191191
method public Integer? getTotalBillableCharacters();
192192
method public int getTotalTokens();
193-
property public final java.util.List<com.google.firebase.vertexai.type.ModalityTokenCount>? promptTokensDetails;
193+
property public final java.util.List<com.google.firebase.vertexai.type.ModalityTokenCount> promptTokensDetails;
194194
property public final Integer? totalBillableCharacters;
195195
property public final int totalTokens;
196196
}
@@ -582,16 +582,16 @@ package com.google.firebase.vertexai.type {
582582
}
583583

584584
public final class UsageMetadata {
585-
ctor public UsageMetadata(int promptTokenCount, Integer? candidatesTokenCount, int totalTokenCount, java.util.List<com.google.firebase.vertexai.type.ModalityTokenCount>? promptTokensDetails, java.util.List<com.google.firebase.vertexai.type.ModalityTokenCount>? candidatesTokensDetails);
585+
ctor public UsageMetadata(int promptTokenCount, Integer? candidatesTokenCount, int totalTokenCount, java.util.List<com.google.firebase.vertexai.type.ModalityTokenCount> promptTokensDetails, java.util.List<com.google.firebase.vertexai.type.ModalityTokenCount> candidatesTokensDetails);
586586
method public Integer? getCandidatesTokenCount();
587-
method public java.util.List<com.google.firebase.vertexai.type.ModalityTokenCount>? getCandidatesTokensDetails();
587+
method public java.util.List<com.google.firebase.vertexai.type.ModalityTokenCount> getCandidatesTokensDetails();
588588
method public int getPromptTokenCount();
589-
method public java.util.List<com.google.firebase.vertexai.type.ModalityTokenCount>? getPromptTokensDetails();
589+
method public java.util.List<com.google.firebase.vertexai.type.ModalityTokenCount> getPromptTokensDetails();
590590
method public int getTotalTokenCount();
591591
property public final Integer? candidatesTokenCount;
592-
property public final java.util.List<com.google.firebase.vertexai.type.ModalityTokenCount>? candidatesTokensDetails;
592+
property public final java.util.List<com.google.firebase.vertexai.type.ModalityTokenCount> candidatesTokensDetails;
593593
property public final int promptTokenCount;
594-
property public final java.util.List<com.google.firebase.vertexai.type.ModalityTokenCount>? promptTokensDetails;
594+
property public final java.util.List<com.google.firebase.vertexai.type.ModalityTokenCount> promptTokensDetails;
595595
property public final int totalTokenCount;
596596
}
597597

firebase-vertexai/src/main/kotlin/com/google/firebase/vertexai/type/CountTokensResponse.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ import kotlinx.serialization.Serializable
3636
public class CountTokensResponse(
3737
public val totalTokens: Int,
3838
public val totalBillableCharacters: Int? = null,
39-
public val promptTokensDetails: List<ModalityTokenCount>? = null,
39+
public val promptTokensDetails: List<ModalityTokenCount> = emptyList(),
4040
) {
4141
public operator fun component1(): Int = totalTokens
4242

@@ -55,7 +55,7 @@ public class CountTokensResponse(
5555
return CountTokensResponse(
5656
totalTokens,
5757
totalBillableCharacters ?: 0,
58-
promptTokensDetails?.map { it.toPublic() }
58+
promptTokensDetails?.map { it.toPublic() } ?: emptyList()
5959
)
6060
}
6161
}

firebase-vertexai/src/main/kotlin/com/google/firebase/vertexai/type/UsageMetadata.kt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,8 @@ public class UsageMetadata(
3333
public val promptTokenCount: Int,
3434
public val candidatesTokenCount: Int?,
3535
public val totalTokenCount: Int,
36-
public val promptTokensDetails: List<ModalityTokenCount>?,
37-
public val candidatesTokensDetails: List<ModalityTokenCount>?,
36+
public val promptTokensDetails: List<ModalityTokenCount>,
37+
public val candidatesTokensDetails: List<ModalityTokenCount>,
3838
) {
3939

4040
@Serializable
@@ -51,8 +51,8 @@ public class UsageMetadata(
5151
promptTokenCount ?: 0,
5252
candidatesTokenCount ?: 0,
5353
totalTokenCount ?: 0,
54-
promptTokensDetails = promptTokensDetails?.map { it.toPublic() },
55-
candidatesTokensDetails = candidatesTokensDetails?.map { it.toPublic() }
54+
promptTokensDetails = promptTokensDetails?.map { it.toPublic() } ?: emptyList(),
55+
candidatesTokensDetails = candidatesTokensDetails?.map { it.toPublic() } ?: emptyList()
5656
)
5757
}
5858
}

firebase-vertexai/src/test/java/com/google/firebase/vertexai/UnarySnapshotTests.kt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -289,6 +289,7 @@ internal class UnarySnapshotTests {
289289
response.candidates.first().finishReason shouldBe FinishReason.STOP
290290
response.usageMetadata shouldNotBe null
291291
response.usageMetadata?.totalTokenCount shouldBe 363
292+
response.usageMetadata?.promptTokensDetails?.isEmpty() shouldBe true
292293
}
293294
}
294295

@@ -478,6 +479,7 @@ internal class UnarySnapshotTests {
478479

479480
response.totalTokens shouldBe 6
480481
response.totalBillableCharacters shouldBe 16
482+
response.promptTokensDetails.isEmpty() shouldBe true
481483
}
482484
}
483485

0 commit comments

Comments
 (0)