Skip to content

Commit 304281a

Browse files
committed
Add changes for cold start logging and TODO for app state change
1 parent 0d9ba90 commit 304281a

File tree

3 files changed

+7
-4
lines changed

3 files changed

+7
-4
lines changed

firebase-perf/src/main/java/com/google/firebase/perf/session/FirebasePerformanceSessionSubscriber.kt

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,12 +28,17 @@ class FirebasePerformanceSessionSubscriber(override val isDataCollectionEnabled:
2828

2929
override fun onSessionChanged(sessionDetails: SessionSubscriber.SessionDetails) {
3030
val currentPerfSession = SessionManager.getInstance().perfSession()
31-
// TODO(b/394127311): Add logic to deal with app start gauges.
3231
FirebaseSessionsEnforcementCheck.checkSession(currentPerfSession, "onSessionChanged")
3332

33+
if (currentPerfSession.isLegacy()) {
34+
GaugeManager.getInstance().logGaugeMetadata(sessionDetails.sessionId, ApplicationProcessState.FOREGROUND)
35+
GaugeManager.getInstance().logExistingGaugeMetrics(sessionDetails.sessionId, ApplicationProcessState.FOREGROUND)
36+
}
37+
3438
val updatedSession = PerfSession.createWithId(sessionDetails.sessionId)
3539
SessionManager.getInstance().updatePerfSession(updatedSession)
3640
GaugeManager.getInstance()
3741
.logGaugeMetadata(updatedSession.sessionId(), ApplicationProcessState.FOREGROUND)
42+
// TODO(b/394127311): Update app state change and start logging if necessary.
3843
}
3944
}

firebase-perf/src/main/java/com/google/firebase/perf/session/PerfSession.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
public class PerfSession implements Parcelable {
3131
private final Timer creationTime;
3232
private final String sessionId;
33-
private boolean isGaugeAndEventCollectionEnabled = false;
33+
private boolean isGaugeAndEventCollectionEnabled = true;
3434

3535
/*
3636
* Creates a PerfSession object and decides what metrics to collect.

firebase-perf/src/main/java/com/google/firebase/perf/session/SessionManager.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,6 @@
2323
import com.google.firebase.perf.logging.FirebaseSessionsEnforcementCheck;
2424
import com.google.firebase.perf.session.gauges.GaugeManager;
2525
import com.google.firebase.perf.v1.ApplicationProcessState;
26-
import com.google.firebase.perf.v1.GaugeMetadata;
27-
import com.google.firebase.perf.v1.GaugeMetric;
2826
import java.lang.ref.WeakReference;
2927
import java.util.HashSet;
3028
import java.util.Iterator;

0 commit comments

Comments
 (0)