Skip to content

Commit 30ba97d

Browse files
Apply suggestions from code review
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
1 parent 510dd82 commit 30ba97d

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

Jules.md

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@ To work with this repository, the Android SDK must be installed. Use the `sdkman
2020
1. **Install Android SDK Command-Line Tools**:
2121
- If not already installed, download the command-line tools from the [Android Studio page](https://developer.android.com/studio#command-line-tools-only).
2222
- Create a directory for the Android SDK, e.g., `android_sdk`.
23-
- Unzip the downloaded package and move the `cmdline-tools` directory into the `android_sdk` directory.
24-
- The final structure should be `android_sdk/cmdline-tools/`.
23+
- Unzip the downloaded package. This will create a `cmdline-tools` directory. Move this directory to `android_sdk/cmdline-tools/latest`.
24+
- The final structure should be `android_sdk/cmdline-tools/latest/`.
2525

2626
2. **Install required SDK packages**:
2727
- Use `sdkmanager` to install the necessary platforms, build tools, and other packages. For example:
@@ -41,6 +41,9 @@ To work with this repository, the Android SDK must be installed. Use the `sdkman
4141
- To run integration tests, a `google-services.json` file is required.
4242
- Place this file in the root of the repository.
4343

44+
4. **Install NDK for specific projects**:
45+
- Some projects, like `firebase-crashlytics-ndk`, require a specific version of the Android NDK. You can install it using `sdkmanager`. For example, to install NDK version 21.4.7075529, you would run `sdkmanager "ndk;21.4.7075529"`. Always refer to the project's `README.md` for the exact version required.
46+
4447
---
4548
4649
## Testing
@@ -70,7 +73,7 @@ The public API of the Firebase SDKs is managed using a set of annotations:
7073
7174
- `@PublicApi`: Marks APIs that are intended for public consumption by developers.
7275
- `@KeepForSdk`: Marks APIs that are intended for use by other Firebase SDKs. These APIs will trigger a linter error if used by developers outside of a Firebase package.
73-
- `@Keep`: Marks APIs that need to be preserved at runtime, usually due to reflection. This annotation should be used sparingly as it prevents the code from being proguarded.
76+
- `@Keep`: Marks APIs that need to be preserved at runtime, usually due to reflection. This annotation should be used sparingly as it prevents Proguard from removing or renaming the code.
7477
7578
---
7679

0 commit comments

Comments
 (0)