Skip to content

Commit 347cfd1

Browse files
committed
README.md: apply code review feedback
1 parent 6175cf7 commit 347cfd1

File tree

1 file changed

+8
-14
lines changed

1 file changed

+8
-14
lines changed

firebase-dataconnect/README.md

Lines changed: 8 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# firebase-dataconnect
22

3-
This is the Firebase Data Connect component of the Firebase Android SDK.
3+
This is the Firebase Android Data Connect SDK.
44

55
## Building
66

@@ -22,8 +22,8 @@ To run unit tests for Firebase Data Connect, from the source root run:
2222

2323
## Integration Testing
2424

25-
Running integration tests requires a Firebase project because they would try
26-
to connect to the Firebase Data Connect backends.
25+
Running integration tests requires a Firebase project because they connect to
26+
the Firebase Data Connect backend.
2727

2828
See [here](../README.md#project-setup) for how to setup a project.
2929

@@ -38,8 +38,7 @@ By default, integration tests run against the Firebase Data Connect emulator.
3838
### Setting up the Firebase Data Connect Emulator
3939

4040
The integration tests require that the Firebase Data Connect emulator is running
41-
on port NNNN (TODO: fill in correct value), which is default when running it via
42-
CLI.
41+
on port 9399, which is default when running it via the Data Connect Toolkit.
4342

4443
* [Install the Firebase CLI](https://firebase.google.com/docs/cli/).
4544
```
@@ -62,15 +61,15 @@ To run the integration tests against prod, select
6261
6362
### Run on Local Android Emulator
6463
65-
Then simply run:
64+
Then run:
6665
```bash
6766
./gradlew :firebase-dataconnect:connectedCheck
6867
```
6968

7069
### Run on Firebase Test Lab
7170

7271
You can also test on Firebase Test Lab, which allow you to run the integration
73-
tests on devices hosted in Google data center.
72+
tests on devices hosted in a Google data center.
7473

7574
See [here](../README.md#running-integration-tests-on-firebase-test-lab) for
7675
instructions of how to setup Firebase Test Lab for your project.
@@ -82,14 +81,9 @@ Run:
8281

8382
## Code Formatting
8483

85-
Run below to format Kotlin code:
84+
Run below to format Kotlin and Java code:
8685
```bash
87-
./gradlew :firebase-dataconnect:ktfmtFormat
88-
```
89-
90-
Run below to format Java code:
91-
```bash
92-
./gradlew :firebase-dataconnect:googleJavaFormat
86+
./gradlew :firebase-dataconnect:spotlessApply
9387
```
9488

9589
See [here](../README.md#code-formatting) if you want to be able to format code

0 commit comments

Comments
 (0)