Skip to content

Commit 3b7bfef

Browse files
[Common] Replace hardcoded SDK version with Config.OLDEST_SDK (#7043)
Tests will use the Config.OLDEST_SDK instead of a hardcoded SDK if the corresponding hardcoded SDK would be below our intended minSdk. I'll also need to re-evaluate whether these tests are necessary to keep around, or if they are irrelevant when bumping the minSdk. Related to cl/769913180 --------- Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
1 parent c6afacd commit 3b7bfef

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

firebase-common/data-collection-tests/src/test/java/com/google/firebase/DataCollectionPreNDefaultDisabledTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,15 +20,15 @@
2020
import static com.google.firebase.DataCollectionTestUtil.withApp;
2121

2222
import android.content.SharedPreferences;
23-
import androidx.test.ext.junit.runners.AndroidJUnit4;
2423
import com.google.firebase.internal.DataCollectionConfigStorage;
2524
import org.junit.Test;
2625
import org.junit.runner.RunWith;
26+
import org.robolectric.RobolectricTestRunner;
2727
import org.robolectric.annotation.Config;
2828
import org.robolectric.annotation.LooperMode;
2929

30-
@RunWith(AndroidJUnit4.class)
31-
@Config(sdk = 21)
30+
@RunWith(RobolectricTestRunner.class)
31+
@Config(sdk = Config.OLDEST_SDK)
3232
public class DataCollectionPreNDefaultDisabledTest {
3333

3434
@Test

0 commit comments

Comments
 (0)