dataconnect.yml: ensure that test logs are uploaded even when the tests fail

Author: dconeybe

.github/workflows/dataconnect.yml

@@ -175,7 +175,12 @@ jobs:
           ${{ env.FDC_FIREBASE_COMMAND }} emulators:start --only=auth >firebase.emulator.auth.log 2>&1 &
 
       - name: Gradle connectedCheck
+        id: connectedCheck
         uses: reactivecircus/android-emulator-runner@v2
+        # Allow this GitHub Actions "job" to continue even if the tests fail so that logs from a
+        # failed test run get uploaded as "artifacts" and are available to investigate failed runs.
+        # A later step in this "job" will fail the job if this step fails
+        continue-on-error: true
         with:
           api-level: ${{ env.FDC_ANDROID_EMULATOR_API_LEVEL }}
           arch: x86_64
@@ -185,21 +190,28 @@ jobs:
           script: |
             set -eux && ./gradlew ${{ (inputs.gradleInfoLog && '--info') || '' }} :firebase-dataconnect:connectedCheck :firebase-dataconnect:connectors:connectedCheck
 
-      - uses: actions/upload-artifact@v4
-        if: true
+      - name: Upload log file artifacts
+        uses: actions/upload-artifact@v4
         with:
           name: logs
           path: "**/*.log"
           if-no-files-found: warn
           compression-level: 9
 
-      - uses: actions/upload-artifact@v4
+      - name: Upload Gradle build report artifacts
+        uses: actions/upload-artifact@v4
         with:
           name: gradle_build_reports
           path: firebase-dataconnect/**/build/reports/
           if-no-files-found: warn
           compression-level: 9
 
+      - name: Check test result
+        if: steps.connectedCheck.outcome != 'success'
+        run: |
+          echo "Failing the job since the connectedCheck step failed"
+          exit 1
+
   # Check this yml file with "actionlint": https://github.com/rhysd/actionlint
   # To run actionlint yourself, run `brew install actionlint` followed by
   # `actionlint .github/workflows/dataconnect.yml`