Skip to content

Commit 4329bc7

Browse files
committed
Fix flaky test
1 parent 125762d commit 4329bc7

File tree

1 file changed

+4
-6
lines changed
  • firebase-crashlytics/src/androidTest/java/com/google/firebase/crashlytics/internal/metadata

1 file changed

+4
-6
lines changed

firebase-crashlytics/src/androidTest/java/com/google/firebase/crashlytics/internal/metadata/MetaDataStoreTest.java

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -168,17 +168,15 @@ public void testWriteUserData_unicode() throws Exception {
168168
}
169169

170170
@Test
171-
// TODO(b/375437048): Let @daymxn know if this test fails. It's flaky and running away from me:(
172171
public void testWriteUserData_escaped() throws Exception {
173172
crashlyticsWorkers.diskWrite.submit(
174-
() -> {
175-
storeUnderTest.writeUserData(
176-
SESSION_ID_1, metadataWithUserId(SESSION_ID_1, ESCAPED).getUserId());
177-
});
173+
() ->
174+
storeUnderTest.writeUserData(
175+
SESSION_ID_1, metadataWithUserId(SESSION_ID_1, ESCAPED).getUserId()));
178176
crashlyticsWorkers.diskWrite.await();
177+
Thread.sleep(10);
179178
UserMetadata userData =
180179
UserMetadata.loadFromExistingSession(SESSION_ID_1, fileStore, crashlyticsWorkers);
181-
Thread.sleep(10);
182180
assertEquals(ESCAPED.trim(), userData.getUserId());
183181
}
184182

0 commit comments

Comments
 (0)