fixes

Author: dconeybe

firebase-dataconnect/ci/notify_issue.py

@@ -12,58 +12,70 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
+from __future__ import annotations
+
 import argparse
 import dataclasses
 import logging
 import sys
 import typing
-from collections.abc import Sequence
+from typing import override
+
+if typing.TYPE_CHECKING:
+  from collections.abc import Sequence
+  from typing import Never, TextIO
+
+  from _typeshed import SupportsWrite
 
 type ExitCode = int
 
-def main(args: Sequence[str], stdout: typing.TextIO, stderr: typing.TextIO) -> ExitCode:
+
+def main(args: Sequence[str], stdout: TextIO, stderr: TextIO) -> ExitCode:
   try:
     parsed_args = parse_args(args[0], args[1:], stdout)
   except MyArgumentParser.Error as e:
     if e.exit_code != 0:
       print(f"ERROR: invalid command-line arguments: {e}", file=stderr)
-      print(f"Run with --help for help", file=stderr)
+      print("Run with --help for help", file=stderr)
     return e.exit_code
 
+  print(f"Successfully parsed arguments: {parsed_args!r}")
   return 0
 
+
 @dataclasses.dataclass(frozen=True)
 class GetIssueNumberCommand:
   github_ref: str
   github_event_name: str
   default_github_issue: int
 
+
 @dataclasses.dataclass(frozen=True)
 class ParsedArgs:
   log_level: int
   command: GetIssueNumberCommand
 
-class MyArgumentParser(argparse.ArgumentParser):
 
-  def __init__(self, prog: str, stdout: typing.TextIO) -> None:
+class MyArgumentParser(argparse.ArgumentParser):
+  def __init__(self, prog: str, stdout: SupportsWrite[str]) -> None:
     super().__init__(prog=prog, usage="%(prog)s <command> [options]")
     self.stdout = stdout
 
-  @typing.override
-  def exit(self, status: int = 0, message: str | None = None) -> typing.Never:
+  @override
+  def exit(self, status: int = 0, message: str | None = None) -> Never:
     raise self.Error(exit_code=status, message=message)
 
-  @typing.override
-  def error(self, message: str) -> typing.Never:
+  @override
+  def error(self, message: str) -> Never:
     self.exit(2, message)
 
-  @typing.override
-  def print_usage(self, file: typing.TextIO | None = None) -> None:
+  @override
+  def print_usage(self, file: SupportsWrite[str] | None = None) -> None:
     file = file if file is not None else self.stdout
     super().print_usage(file)
 
-  @typing.override
-  def print_help(self, file: typing.TextIO | None =None) -> None:
+  @override
+  def print_help(self, file: SupportsWrite[str] | None = None) -> None:
     file = file if file is not None else self.stdout
     super().print_help(file)
 
@@ -73,9 +85,19 @@ def __init__(self, exit_code: ExitCode, message: str | None) -> None:
       self.exit_code = exit_code
 
 
-def parse_args(prog: str, args: Sequence[str], stdout: typing.TextIO) -> ExitCode:
+def parse_args(prog: str, args: Sequence[str], stdout: TextIO) -> ParsedArgs:
   arg_parser = MyArgumentParser(prog, stdout)
   parsed_args = arg_parser.parse_args(args)
+  print(f"parsed_args: {parsed_args!r}")
+  return ParsedArgs(
+    log_level=logging.INFO,
+    command=GetIssueNumberCommand(
+      github_ref="sample_github_ref",
+      github_event_name="sample_github_event_name",
+      default_github_issue=123456,
+    ),
+  )
+
 
 if __name__ == "__main__":
   try:

firebase-dataconnect/ci/pyproject.toml

@@ -14,6 +14,10 @@ indent-width = 2
 select = ["ALL"]
 ignore = [
   "D100", # Missing docstring in public module
+  "D101", # Missing docstring in public class
+  "D103", # Missing docstring in public function
+  "D106", # Missing docstring in public nested class
+  "D107", # Missing docstring in `__init__`
   "D211", # no-blank-line-before-class
   "D212", # multi-line-summary-second-line
   "T201", # print` found