Skip to content

Commit 4966149

Browse files
committed
Merge branch 'releases/m159.release' of https://github.com/firebase/firebase-android-sdk into releases/m159.release
2 parents 972a7ea + f9527d4 commit 4966149

File tree

3 files changed

+74
-5
lines changed

3 files changed

+74
-5
lines changed

release.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
"name": "m159",
33
"libraries": [
44
":firebase-firestore",
5-
":firebase-firestore:ktx"
5+
":firebase-firestore:ktx",
6+
":firebase-vertexai"
67
]
78
}

release_report.json

Lines changed: 51 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,59 @@
1111
}
1212
],
1313
"firebase-firestore/ktx": [
14+
],
15+
"firebase-vertexai": [
16+
{
17+
"commitId": "0fac9bf0b28099e8a1f525f6b75f12d2567de97c",
18+
"prId": "6654",
19+
"author": "Daymon",
20+
"message": "Add missing changelog (#6654)\n\nAdds the changelog entry for #6652",
21+
"commitLink": "https://github.com/firebase/firebase-android-sdk/commit/0fac9bf0b28099e8a1f525f6b75f12d2567de97c",
22+
"prLink": "https://github.com/firebase/firebase-android-sdk/pull/6654"
23+
},
24+
{
25+
"commitId": "31e0d061c4f8e86bac001baace7a998b945334a4",
26+
"prId": "6631",
27+
"author": "emilypgoogle",
28+
"message": "Migrate VertexAI serialization to be localized (#6631)\n\nThere are some considerations to how this should be finalized. Current\r\nimplementation details that I've decided on which we can change:\r\n* Based on the example doc, all classes `Foo` have been renamed\r\n`InternalFoo`\r\n* All internal serialization classes, where relevant, are moved to inner\r\nclasses of their API counterparts\r\n* All classes only used as child fields for serialization classes have\r\nbeen moved to inner classes of those classes\r\n* All `toPublic` and `toInternal` methods on API and serialization\r\nclasses have been moved inside of those classes and `conversions.kt` has\r\nbeen mostly emptied.\r\n* A few serialization classes do not have API equivalents and are left\r\nin a `Types.kt` file\r\n\r\nPossible changes:\r\n* Change all `InternalFoo` classes to have the same name, referenced as\r\n`Foo.Internal` rather than `Foo.InternalFoo`. This will probably make\r\nthe codebase feel cleaner, but I'll wait for opinions on it\r\n* Move serialization only classes out of the internal serialization\r\nclasses, either to inner classes of the API classes or top level classes\r\nthemselves.\r\n* For classes that have serializers, rename serializers from\r\n`InternalFooSerializer` to `Serializer` for example\r\n`Foo.InternalFoo.Serializer` or `Foo.Internal.Serializer` instead of\r\n`Foo.InternalFoo.InternalFooSerializer` or\r\n`Foo.Internal.InternalFooSerializer`",
29+
"commitLink": "https://github.com/firebase/firebase-android-sdk/commit/31e0d061c4f8e86bac001baace7a998b945334a4",
30+
"prLink": "https://github.com/firebase/firebase-android-sdk/pull/6631"
31+
},
32+
{
33+
"commitId": "f2d05d6710a902944fbb75a8e861c78740d7dc84",
34+
"prId": "6651",
35+
"author": "Rodrigo Lazo",
36+
"message": "Update the vertex golden file version being pulled (#6651)\n\nWe've updated from version 3.* to 5.*. Test were added were necessary to\nmatch the coverage in the iOS repo.\n\nA few changes (v5.1 and v5.2) don't have tests covering the new files\nyet",
37+
"commitLink": "https://github.com/firebase/firebase-android-sdk/commit/f2d05d6710a902944fbb75a8e861c78740d7dc84",
38+
"prLink": "https://github.com/firebase/firebase-android-sdk/pull/6651"
39+
},
40+
{
41+
"commitId": "65b23aaad4cac5aeb6df4845f21d07f748c5b022",
42+
"prId": "6652",
43+
"author": "Rodrigo Lazo",
44+
"message": "Drop empty text parts when parsing the model's response (#6652)\n\nEmpty text parts go from a nuance when processed, to an exception when\nsend to the backend. To prevent this issue, we are dropping them when\nparsing the response from the server.",
45+
"commitLink": "https://github.com/firebase/firebase-android-sdk/commit/65b23aaad4cac5aeb6df4845f21d07f748c5b022",
46+
"prLink": "https://github.com/firebase/firebase-android-sdk/pull/6652"
47+
},
48+
{
49+
"commitId": "8567a384ac26bf940ee7a896e674ccf207f40948",
50+
"prId": "6646",
51+
"author": "Rodrigo Lazo",
52+
"message": "Remove preview notice from vertexai readme (#6646)\n\nThe SDK was released as GA last year.",
53+
"commitLink": "https://github.com/firebase/firebase-android-sdk/commit/8567a384ac26bf940ee7a896e674ccf207f40948",
54+
"prLink": "https://github.com/firebase/firebase-android-sdk/pull/6646"
55+
},
56+
{
57+
"commitId": "cf5fe2e8e7b12a53bba085a4ceda0d4c6fd87012",
58+
"prId": "6637",
59+
"author": "Rodrigo Lazo",
60+
"message": "Update code formatting command in vertex's README (#6637)\n\nWe have been using the spotless plugin for a while already.",
61+
"commitLink": "https://github.com/firebase/firebase-android-sdk/commit/cf5fe2e8e7b12a53bba085a4ceda0d4c6fd87012",
62+
"prLink": "https://github.com/firebase/firebase-android-sdk/pull/6637"
63+
}
1464
]
1565
},
1666
"changedLibrariesWithNoChangelog": [
17-
":firebase-dataconnect",
18-
":firebase-vertexai"
67+
":firebase-dataconnect"
1968
]
2069
}

release_report.md

Lines changed: 21 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,26 @@
77
## firebase-firestore/ktx
88
99

10+
## firebase-vertexai
11+
12+
* Add missing changelog (#6654)
13+
[pr](https://github.com/firebase/firebase-android-sdk/pull/6654) [commit](https://github.com/firebase/firebase-android-sdk/commit/0fac9bf0b28099e8a1f525f6b75f12d2567de97c) [Daymon]
14+
15+
* Migrate VertexAI serialization to be localized (#6631)
16+
[pr](https://github.com/firebase/firebase-android-sdk/pull/6631) [commit](https://github.com/firebase/firebase-android-sdk/commit/31e0d061c4f8e86bac001baace7a998b945334a4) [emilypgoogle]
17+
18+
* Update the vertex golden file version being pulled (#6651)
19+
[pr](https://github.com/firebase/firebase-android-sdk/pull/6651) [commit](https://github.com/firebase/firebase-android-sdk/commit/f2d05d6710a902944fbb75a8e861c78740d7dc84) [Rodrigo Lazo]
20+
21+
* Drop empty text parts when parsing the model's response (#6652)
22+
[pr](https://github.com/firebase/firebase-android-sdk/pull/6652) [commit](https://github.com/firebase/firebase-android-sdk/commit/65b23aaad4cac5aeb6df4845f21d07f748c5b022) [Rodrigo Lazo]
23+
24+
* Remove preview notice from vertexai readme (#6646)
25+
[pr](https://github.com/firebase/firebase-android-sdk/pull/6646) [commit](https://github.com/firebase/firebase-android-sdk/commit/8567a384ac26bf940ee7a896e674ccf207f40948) [Rodrigo Lazo]
26+
27+
* Update code formatting command in vertex's README (#6637)
28+
[pr](https://github.com/firebase/firebase-android-sdk/pull/6637) [commit](https://github.com/firebase/firebase-android-sdk/commit/cf5fe2e8e7b12a53bba085a4ceda0d4c6fd87012) [Rodrigo Lazo]
29+
1030

1131
## SDKs with changes, but no changelogs
12-
:firebase-dataconnect
13-
:firebase-vertexai
32+
:firebase-dataconnect

0 commit comments

Comments
 (0)