Skip to content

Commit 537313a

Browse files
committed
Realtime Pipeline Integration with SDK + some minor fixes
1 parent 3065e65 commit 537313a

File tree

8 files changed

+466
-20
lines changed

8 files changed

+466
-20
lines changed

firebase-firestore/src/androidTest/java/com/google/firebase/firestore/PipelineTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -566,7 +566,7 @@ public void testToUppercase() {
566566
firestore
567567
.pipeline()
568568
.collection(randomCol)
569-
.select(field("author").toLower().alias("uppercaseAuthor"))
569+
.select(field("author").toUpper().alias("uppercaseAuthor"))
570570
.limit(1)
571571
.execute();
572572
assertThat(waitFor(execute).getResults())

firebase-firestore/src/androidTest/java/com/google/firebase/firestore/QueryToPipelineTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414

1515
package com.google.firebase.firestore;
1616

17-
import static com.google.common.io.Files.map;
1817
import static com.google.firebase.firestore.Filter.and;
1918
import static com.google.firebase.firestore.Filter.arrayContains;
2019
import static com.google.firebase.firestore.Filter.arrayContainsAny;

firebase-firestore/src/main/java/com/google/firebase/firestore/Pipeline.kt

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@ import com.google.firebase.firestore.pipeline.OffsetStage
4141
import com.google.firebase.firestore.pipeline.Ordering
4242
import com.google.firebase.firestore.pipeline.PipelineOptions
4343
import com.google.firebase.firestore.pipeline.RawStage
44-
import com.google.firebase.firestore.pipeline.RealtimePipelineOptions
4544
import com.google.firebase.firestore.pipeline.RemoveFieldsStage
4645
import com.google.firebase.firestore.pipeline.ReplaceStage
4746
import com.google.firebase.firestore.pipeline.SampleStage
@@ -676,9 +675,10 @@ class PipelineSource internal constructor(private val firestore: FirebaseFiresto
676675
* pipeline.
677676
* @return A new [Pipeline] object with [documents].
678677
*/
679-
fun documents(vararg documents: String): Pipeline =
678+
fun documents(vararg documents: String): Pipeline {
680679
// Validate document path by converting to DocumentReference
681-
documents(*documents.map(firestore::document).toTypedArray())
680+
return documents(*documents.map(firestore::document).toTypedArray())
681+
}
682682

683683
/**
684684
* Set the pipeline's source to the documents specified by the given DocumentReferences.
@@ -771,10 +771,6 @@ internal constructor(
771771

772772
private fun append(stage: Stage<*>): RealtimePipeline = with(stages.plus(stage))
773773

774-
fun execute(): Task<PipelineSnapshot> = execute(null)
775-
776-
fun execute(options: RealtimePipelineOptions): Task<PipelineSnapshot> = execute(options.options)
777-
778774
fun limit(limit: Int): RealtimePipeline = append(LimitStage(limit))
779775

780776
fun offset(offset: Int): RealtimePipeline = append(OffsetStage(offset))

0 commit comments

Comments
 (0)