Skip to content

Commit 59eb4ae

Browse files
committed
fix after merge
1 parent e823b63 commit 59eb4ae

File tree

3 files changed

+14
-9
lines changed

3 files changed

+14
-9
lines changed

firebase-firestore/src/main/java/com/google/firebase/firestore/Pipeline.kt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ class Pipeline
131131
private constructor(
132132
firestore: FirebaseFirestore,
133133
userDataReader: UserDataReader,
134-
stages: FluentIterable<Stage<*>>
134+
stages: FluentIterable<BaseStage<*>>
135135
) : AbstractPipeline(firestore, userDataReader, stages) {
136136
internal constructor(
137137
firestore: FirebaseFirestore,
@@ -760,15 +760,15 @@ class RealtimePipeline
760760
internal constructor(
761761
firestore: FirebaseFirestore,
762762
userDataReader: UserDataReader,
763-
stages: FluentIterable<Stage<*>>
763+
stages: FluentIterable<BaseStage<*>>
764764
) : AbstractPipeline(firestore, userDataReader, stages) {
765765
internal constructor(
766766
firestore: FirebaseFirestore,
767767
userDataReader: UserDataReader,
768-
stage: Stage<*>
768+
stage: BaseStage<*>
769769
) : this(firestore, userDataReader, FluentIterable.of(stage))
770770

771-
private fun append(stage: Stage<*>): RealtimePipeline {
771+
private fun append(stage: BaseStage<*>): RealtimePipeline {
772772
return RealtimePipeline(firestore, userDataReader, stages.append(stage))
773773
}
774774

firebase-firestore/src/main/java/com/google/firebase/firestore/model/Values.kt

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -663,14 +663,17 @@ internal object Values {
663663
)
664664
}
665665

666+
@JvmStatic
667+
fun encodeValue(value: Timestamp): Value = Value.newBuilder().setTimestampValue(value).build()
668+
666669
@JvmField
667-
val TRUE: Value = Value.newBuilder().setBooleanValue(true).build()
670+
val TRUE_VALUE: Value = Value.newBuilder().setBooleanValue(true).build()
668671

669672
@JvmField
670-
val FALSE: Value = Value.newBuilder().setBooleanValue(false).build()
673+
val FALSE_VALUE: Value = Value.newBuilder().setBooleanValue(false).build()
671674

672675
@JvmStatic
673-
fun encodeValue(value: Boolean): Value = if (value) TRUE else FALSE
676+
fun encodeValue(value: Boolean): Value = if (value) TRUE_VALUE else FALSE_VALUE
674677

675678
@JvmStatic
676679
fun encodeValue(geoPoint: GeoPoint): Value =

firebase-firestore/src/main/java/com/google/firebase/firestore/pipeline/expressions.kt

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2954,7 +2954,8 @@ abstract class Expr internal constructor() {
29542954
* @return A new [BooleanExpr] representing the ifError operation.
29552955
*/
29562956
@JvmStatic
2957-
fun ifError(tryExpr: BooleanExpr, catchExpr: BooleanExpr): BooleanExpr = BooleanExpr("if_error", tryExpr, catchExpr)
2957+
fun ifError(tryExpr: BooleanExpr, catchExpr: BooleanExpr): BooleanExpr =
2958+
BooleanExpr("if_error", notImplemented, tryExpr, catchExpr)
29582959

29592960
/**
29602961
* Creates an expression that returns the [catchValue] argument if there is an error, else
@@ -4217,9 +4218,10 @@ internal constructor(name: String, function: EvaluateFunction, params: Array<out
42174218
) : this(name, function, arrayOf(param))
42184219
internal constructor(
42194220
name: String,
4221+
function: EvaluateFunction,
42204222
param1: Expr,
42214223
param2: Any
4222-
) : this(name, arrayOf(param1, toExprOrConstant(param2)))
4224+
) : this(name, function, arrayOf(param1, toExprOrConstant(param2)))
42234225
internal constructor(
42244226
name: String,
42254227
function: EvaluateFunction,

0 commit comments

Comments
 (0)