Add Arithmetic tests

Author: tom-andersen

firebase-firestore/src/main/java/com/google/firebase/firestore/pipeline/EvaluateResult.kt

@@ -6,6 +6,8 @@ import com.google.firestore.v1.Value
 import com.google.protobuf.Timestamp
 
 internal sealed class EvaluateResult(val value: Value?) {
+  abstract val isError: Boolean
+
   companion object {
     val TRUE: EvaluateResultValue = EvaluateResultValue(Values.TRUE_VALUE)
     val FALSE: EvaluateResultValue = EvaluateResultValue(Values.FALSE_VALUE)
@@ -24,12 +26,16 @@ internal sealed class EvaluateResult(val value: Value?) {
       if (seconds !in -62_135_596_800 until 253_402_300_800) EvaluateResultError
       else timestamp(Values.timestamp(seconds, nanos))
   }
-  internal inline fun evaluateNonNull(f: (Value) -> EvaluateResult): EvaluateResult =
-    if (value?.hasNullValue() == true) f(value) else this
 }
 
-internal object EvaluateResultError : EvaluateResult(null)
+internal object EvaluateResultError : EvaluateResult(null) {
+  override val isError: Boolean = true
+}
 
-internal object EvaluateResultUnset : EvaluateResult(null)
+internal object EvaluateResultUnset : EvaluateResult(null) {
+  override val isError: Boolean = false
+}
 
-internal class EvaluateResultValue(value: Value) : EvaluateResult(value)
+internal class EvaluateResultValue(value: Value) : EvaluateResult(value) {
+  override val isError: Boolean = false
+}

firebase-firestore/src/main/java/com/google/firebase/firestore/pipeline/evaluation.kt

@@ -138,7 +138,7 @@ internal val evaluateDivide = arithmeticPrimitive(Long::div, Double::div)
 
 internal val evaluateFloor = arithmeticPrimitive({ it }, Math::floor)
 
-internal val evaluateMod = arithmeticPrimitive(Long::mod, Double::mod)
+internal val evaluateMod = arithmeticPrimitive(Long::rem, Double::rem)
 
 internal val evaluateMultiply: EvaluateFunction =
   arithmeticPrimitive(Math::multiplyExact, Double::times)