Resolve comments

Author: emilypgoogle

.github/workflows/metalava-semver-check.yml

@@ -23,7 +23,7 @@ jobs:
           distribution: temurin
           cache: gradle
 
-      - name: Copy new api.txt files
+      - name: Copy existing api.txt files
         run: ./gradlew copyApiTxtFile
 
       - name: Checkout PR

plugins/src/main/java/com/google/firebase/gradle/plugins/BaseFirebaseLibraryPlugin.kt

@@ -127,6 +127,20 @@ abstract class BaseFirebaseLibraryPlugin : Plugin<Project> {
     Coverage.apply(library)
   }
 
+  protected fun setupMetalavaSemver(project: Project, library: FirebaseLibraryExtension) {
+    project.tasks.register<CopyApiTask>("copyApiTxtFile") {
+      apiTxtFile.set(project.file("api.txt"))
+      output.set(project.file("existing_api.txt"))
+    }
+
+    project.tasks.register<SemVerTask>("metalavaSemver") {
+      apiTxtFile.set(project.file("api.txt"))
+      existingApiFile.set(project.file("existing_api.txt"))
+      currentVersionString.value(library.version)
+      previousVersionString.value(library.previousVersion)
+    }
+  }
+
   protected fun getApiInfo(
     project: Project,
     srcDirs: ConfigurableFileCollection,

plugins/src/main/java/com/google/firebase/gradle/plugins/FirebaseAndroidLibraryPlugin.kt

@@ -161,17 +161,7 @@ class FirebaseAndroidLibraryPlugin : BaseFirebaseLibraryPlugin() {
       )
     }
 
-    project.tasks.register<CopyApiTask>("copyApiTxtFile") {
-      apiTxtFile.set(project.file("api.txt"))
-      output.set(project.file("old_api.txt"))
-    }
-
-    project.tasks.register<SemVerTask>("metalavaSemver") {
-      apiTxtFile.set(project.file("api.txt"))
-      otherApiFile.set(project.file("old_api.txt"))
-      currentVersionString.value(firebaseLibrary.version)
-      previousVersionString.value(firebaseLibrary.previousVersion)
-    }
+    setupMetalavaSemver(project, firebaseLibrary)
   }
 
   private fun setupApiInformationAnalysis(project: Project, android: LibraryExtension) {

plugins/src/main/java/com/google/firebase/gradle/plugins/FirebaseJavaLibraryPlugin.kt

@@ -104,17 +104,7 @@ class FirebaseJavaLibraryPlugin : BaseFirebaseLibraryPlugin() {
       dependsOn("copyPreviousArtifacts")
     }
 
-    project.tasks.register<CopyApiTask>("copyApiTxtFile") {
-      apiTxtFile.set(project.file("api.txt"))
-      output.set(project.file("old_api.txt"))
-    }
-
-    project.tasks.register<SemVerTask>("metalavaSemver") {
-      apiTxtFile.set(project.file("api.txt"))
-      otherApiFile.set(project.file("old_api.txt"))
-      currentVersionString.value(firebaseLibrary.version)
-      previousVersionString.value(firebaseLibrary.previousVersion)
-    }
+    setupMetalavaSemver(project, firebaseLibrary)
   }
 
   private fun setupApiInformationAnalysis(project: Project) {

plugins/src/main/java/com/google/firebase/gradle/plugins/SemVerTask.kt

@@ -28,7 +28,7 @@ import org.gradle.api.tasks.TaskAction
 
 abstract class SemVerTask : DefaultTask() {
   @get:InputFile abstract val apiTxtFile: RegularFileProperty
-  @get:InputFile abstract val otherApiFile: RegularFileProperty
+  @get:InputFile abstract val existingApiFile: RegularFileProperty
   @get:Input abstract val currentVersionString: Property<String>
   @get:Input abstract val previousVersionString: Property<String>
 
@@ -51,7 +51,7 @@ abstract class SemVerTask : DefaultTask() {
         "--source-files",
         apiTxtFile.get().asFile.absolutePath,
         "--check-compatibility:api:released",
-        otherApiFile.get().asFile.absolutePath,
+        existingApiFile.get().asFile.absolutePath,
       ) +
         MAJOR.flatMap { m -> listOf("--error", m) } +
         MINOR.flatMap { m -> listOf("--error", m) } +