Various app-check fixes. (#2911)

Author: vkryachko

appcheck/firebase-appcheck-debug-testing/src/main/AndroidManifest.xml

@@ -13,7 +13,8 @@
 <!-- See the License for the specific language governing permissions and -->
 <!-- limitations under the License. -->
 
-<manifest package="com.google.firebase.appcheck.debug.testing">
+<manifest xmlns:android="http://schemas.android.com/apk/res/android"
+    package="com.google.firebase.appcheck.debug.testing">
   <!--Although the *SdkVersion is captured in gradle build files, this is required for non gradle builds-->
   <!--<uses-sdk android:minSdkVersion="16"/>-->
 </manifest>

appcheck/firebase-appcheck-debug/src/main/AndroidManifest.xml

@@ -13,7 +13,8 @@
 <!-- See the License for the specific language governing permissions and -->
 <!-- limitations under the License. -->
 
-<manifest package="com.google.firebase.appcheck.debug">
+<manifest  xmlns:android="http://schemas.android.com/apk/res/android"
+    package="com.google.firebase.appcheck.debug">
   <!--Although the *SdkVersion is captured in gradle build files, this is required for non gradle builds-->
   <!--<uses-sdk android:minSdkVersion="16"/>-->
 </manifest>

appcheck/firebase-appcheck-debug/src/main/java/com/google/firebase/appcheck/debug/internal/DebugAppCheckProvider.java

@@ -68,7 +68,7 @@ public DebugAppCheckProvider(@NonNull FirebaseApp firebaseApp, @Nullable String
   static Task<String> determineDebugSecret(
       @NonNull FirebaseApp firebaseApp, @NonNull ExecutorService executor) {
     TaskCompletionSource<String> taskCompletionSource = new TaskCompletionSource<>();
-    executor.submit(
+    executor.execute(
         () -> {
           StorageHelper storageHelper =
               new StorageHelper(

appcheck/firebase-appcheck-interop/src/main/AndroidManifest.xml

@@ -13,7 +13,8 @@
 <!-- See the License for the specific language governing permissions and -->
 <!-- limitations under the License. -->
 
-<manifest package="com.google.firebase.appcheck.interop">
+<manifest xmlns:android="http://schemas.android.com/apk/res/android"
+    package="com.google.firebase.appcheck.interop">
     <!--Although the *SdkVersion is captured in gradle build files, this is required for non gradle builds-->
     <!--<uses-sdk android:minSdkVersion="16"/>-->
     <application />

appcheck/firebase-appcheck-safetynet/src/main/AndroidManifest.xml

@@ -13,7 +13,8 @@
 <!-- See the License for the specific language governing permissions and -->
 <!-- limitations under the License. -->
 
-<manifest package="com.google.firebase.appcheck.safetynet">
+<manifest xmlns:android="http://schemas.android.com/apk/res/android"
+    package="com.google.firebase.appcheck.safetynet">
     <!--Although the *SdkVersion is captured in gradle build files, this is required for non gradle builds-->
     <!--<uses-sdk android:minSdkVersion="16"/>-->
 </manifest>

appcheck/firebase-appcheck-safetynet/src/main/java/com/google/firebase/appcheck/safetynet/internal/SafetyNetAppCheckProvider.java

@@ -88,7 +88,7 @@ public SafetyNetAppCheckProvider(@NonNull FirebaseApp firebaseApp) {
   private Task<SafetyNetClient> initSafetyNetClient(
       GoogleApiAvailability googleApiAvailability, ExecutorService executor) {
     TaskCompletionSource<SafetyNetClient> taskCompletionSource = new TaskCompletionSource<>();
-    executor.submit(
+    executor.execute(
         () -> {
           int connectionResult = googleApiAvailability.isGooglePlayServicesAvailable(context);
           if (connectionResult == ConnectionResult.SUCCESS) {