rename

Author: tejasd

firebase-perf/src/test/java/com/google/firebase/perf/config/RemoteConfigManagerTest.java

@@ -861,20 +861,20 @@ public void triggerRemoteConfigFetchIfNecessary_doesNotFetchBeforeRandomDelay()
   }
 
   @Test
-  public void triggerRemoteConfigFetchIfNecessary_fetchesAfterAppStartRandomDelay() {
-    long appStartConfigFetchDelay = 5000;
+  public void triggerRemoteConfigFetchIfNecessary_fetchesAfterRandomDelay() {
+    long remoteConfigFetchDelay = 5000;
     RemoteConfigManager remoteConfigManagerPartialMock =
         spy(
             setupTestRemoteConfigManager(
                 createFakeTaskThatDoesNothing(),
                 true,
                 createDefaultRcConfigMap(),
-                appStartConfigFetchDelay));
+                remoteConfigFetchDelay));
 
     // Simulate time fast forward to 2s after fetch delay time is up
-    long appStartTimeInMs = System.currentTimeMillis();
+    long approxRcmInitTimestampInMs = System.currentTimeMillis();
     when(remoteConfigManagerPartialMock.getCurrentSystemTimeMillis())
-        .thenReturn(appStartTimeInMs + appStartConfigFetchDelay + 2000);
+        .thenReturn(approxRcmInitTimestampInMs + remoteConfigFetchDelay + 2000);
 
     simulateFirebaseRemoteConfigLastFetchStatus(
         FirebaseRemoteConfig.LAST_FETCH_STATUS_NO_FETCH_YET);
@@ -918,19 +918,16 @@ private RemoteConfigManager setupTestRemoteConfigManager(
       Task<Boolean> fakeTask,
       boolean initializeFrc,
       Map<String, FirebaseRemoteConfigValue> configs,
-      long appStartConfigFetchDelayInMs) {
+      long remoteConfigFetchDelayInMs) {
     simulateFirebaseRemoteConfigLastFetchStatus(FirebaseRemoteConfig.LAST_FETCH_STATUS_SUCCESS);
     when(mockFirebaseRemoteConfig.fetchAndActivate()).thenReturn(fakeTask);
     when(mockFirebaseRemoteConfig.getAll()).thenReturn(configs);
     if (initializeFrc) {
       return new RemoteConfigManager(
-          cacheManager, fakeExecutor, mockFirebaseRemoteConfig, appStartConfigFetchDelayInMs);
+          cacheManager, fakeExecutor, mockFirebaseRemoteConfig, remoteConfigFetchDelayInMs);
     } else {
       return new RemoteConfigManager(
-          cacheManager,
-          fakeExecutor,
-          /* firebaseRemoteConfig= */ null,
-          appStartConfigFetchDelayInMs);
+          cacheManager, fakeExecutor, /* firebaseRemoteConfig= */ null, remoteConfigFetchDelayInMs);
     }
   }