Skip to content

Commit 7f73aaf

Browse files
committed
dataconnect_demo_app.yml/dataconnect-send-notifications/action.yml: move secrets into main workflow and explicitly specify shell:bash
1 parent 6e85e2f commit 7f73aaf

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

.github/actions/dataconnect-send-notifications/action.yml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,13 @@ runs:
1818
python-version: ${{ inputs.python-version }}
1919

2020
- run: pip install -r requirements.txt
21+
shell: bash
2122
working-directory: firebase-dataconnect/ci
2223

2324
- id: issue-id
2425
name: Determine GitHub Issue For Commenting
2526
working-directory: firebase-dataconnect/ci
26-
env:
27-
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
27+
shell: bash
2828
run: |
2929
args=(
3030
python
@@ -49,8 +49,7 @@ runs:
4949
- name: Post Comment on GitHub Issue
5050
if: steps.issue-id.outputs.issue != ''
5151
working-directory: firebase-dataconnect/ci
52-
env:
53-
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
52+
shell: bash
5453
run: |
5554
args=(
5655
python

.github/workflows/dataconnect_demo_app.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -183,6 +183,9 @@ jobs:
183183
firebase-dataconnect/ci/
184184
.github/actions/dataconnect-send-notifications/
185185
186+
- name: gh auth login
187+
run: echo '${{ secrets.GITHUB_TOKEN }}' | gh auth login --with-token
188+
186189
- name: Create Job Results File
187190
id: create-job-results-file
188191
run: |

0 commit comments

Comments
 (0)