Rename "old" state variables to "current" state, as suggested by Copilot: #6840 (review)

Author: dconeybe

firebase-dataconnect/src/main/kotlin/com/google/firebase/dataconnect/core/DataConnectCredentialsTokenManager.kt

@@ -193,12 +193,12 @@ internal sealed class DataConnectCredentialsTokenManager<T : Any>(
   fun forceRefresh() {
     logger.debug { "forceRefresh()" }
     val oldState =
-      state.getAndUpdate { oldState ->
-        when (oldState) {
+      state.getAndUpdate { currentState ->
+        when (currentState) {
           is State.Closed -> State.Closed
-          is State.New -> oldState.copy(forceTokenRefresh = true)
-          is State.Idle -> oldState.copy(forceTokenRefresh = true)
-          is State.Active -> State.Idle(oldState.provider, forceTokenRefresh = true)
+          is State.New -> currentState.copy(forceTokenRefresh = true)
+          is State.Idle -> currentState.copy(forceTokenRefresh = true)
+          is State.Active -> State.Idle(currentState.provider, forceTokenRefresh = true)
         }
       }
 
@@ -340,11 +340,11 @@ internal sealed class DataConnectCredentialsTokenManager<T : Any>(
     addTokenListener(newProvider)
 
     val oldState =
-      state.getAndUpdate { oldState ->
-        when (oldState) {
+      state.getAndUpdate { currentState ->
+        when (currentState) {
           is State.Closed -> State.Closed
-          is State.New -> State.Idle(newProvider, oldState.forceTokenRefresh)
-          is State.Idle -> State.Idle(newProvider, oldState.forceTokenRefresh)
+          is State.New -> State.Idle(newProvider, currentState.forceTokenRefresh)
+          is State.Idle -> State.Idle(newProvider, currentState.forceTokenRefresh)
           is State.Active -> State.Idle(newProvider, forceTokenRefresh = false)
         }
       }

firebase-dataconnect/src/main/kotlin/com/google/firebase/dataconnect/core/FirebaseDataConnectImpl.kt

@@ -425,9 +425,9 @@ internal class FirebaseDataConnectImpl(
     // avoid having more than one close job in progress at a time) or a close job that completed
     // successfully (since there is nothing to do if a previous close job was successful).
     val updatedCloseJobRef =
-      closeJob.updateAndGet { oldCloseJobRef: NullableReference<Deferred<Unit>> ->
-        if (oldCloseJobRef.ref !== null && !oldCloseJobRef.ref.isCancelled) {
-          oldCloseJobRef
+      closeJob.updateAndGet { currentCloseJobRef: NullableReference<Deferred<Unit>> ->
+        if (currentCloseJobRef.ref !== null && !currentCloseJobRef.ref.isCancelled) {
+          currentCloseJobRef
         } else {
           NullableReference(newCloseJob)
         }

firebase-dataconnect/testutil/src/main/kotlin/com/google/firebase/dataconnect/testutil/SuspendingCountDownLatch.kt

@@ -61,9 +61,9 @@ class SuspendingCountDownLatch(count: Int) {
    * @throws IllegalStateException if called when the count has already reached zero.
    */
   fun countDown(): SuspendingCountDownLatch {
-    _count.update { oldValue ->
-      check(oldValue > 0) { "countDown() called too many times (oldValue=$oldValue)" }
-      oldValue - 1
+    _count.update { currentValue ->
+      check(currentValue > 0) { "countDown() called too many times (currentValue=$currentValue)" }
+      currentValue - 1
     }
     return this
   }