Skip to content

Commit a104ea4

Browse files
committed
Update logging for sessions list
1 parent 20f96e0 commit a104ea4

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

firebase-perf/src/main/java/com/google/firebase/perf/logging/FirebaseSessionsEnforcementCheck.kt

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,10 @@ class FirebaseSessionsEnforcementCheck {
2626
private var logger: AndroidLogger = AndroidLogger.getInstance()
2727

2828
@JvmStatic
29-
fun checkSession(sessions: List<ProtoPerfSession>, failureMessage: String) {
30-
sessions.forEach { checkSession(it.sessionId, failureMessage) }
29+
fun checkSessionsList(sessions: List<ProtoPerfSession>, failureMessage: String) {
30+
if (sessions.count { it.sessionId.isLegacy() } == sessions.size) {
31+
sessions.forEach { checkSession(it.sessionId, failureMessage) }
32+
}
3133
}
3234

3335
@JvmStatic

firebase-perf/src/main/java/com/google/firebase/perf/transport/TransportManager.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
package com.google.firebase.perf.transport;
1616

1717
import static com.google.firebase.perf.logging.FirebaseSessionsEnforcementCheck.checkSession;
18+
import static com.google.firebase.perf.logging.FirebaseSessionsEnforcementCheck.checkSessionsList;
1819
import static com.google.firebase.perf.util.AppProcessesProvider.getProcessName;
1920
import static java.util.concurrent.TimeUnit.MILLISECONDS;
2021
import static java.util.concurrent.TimeUnit.MINUTES;
@@ -300,7 +301,7 @@ public void log(final TraceMetric traceMetric) {
300301
* {@link #isAllowedToDispatch(PerfMetric)}).
301302
*/
302303
public void log(final TraceMetric traceMetric, final ApplicationProcessState appState) {
303-
checkSession(traceMetric.getPerfSessionsList(), "log(TraceMetric)");
304+
checkSessionsList(traceMetric.getPerfSessionsList(), "log(TraceMetric)");
304305
executorService.execute(
305306
() -> syncLog(PerfMetric.newBuilder().setTraceMetric(traceMetric), appState));
306307
}
@@ -329,7 +330,7 @@ public void log(final NetworkRequestMetric networkRequestMetric) {
329330
*/
330331
public void log(
331332
final NetworkRequestMetric networkRequestMetric, final ApplicationProcessState appState) {
332-
checkSession(networkRequestMetric.getPerfSessionsList(), "log(NetworkRequestMetric)");
333+
checkSessionsList(networkRequestMetric.getPerfSessionsList(), "log(NetworkRequestMetric)");
333334
executorService.execute(
334335
() ->
335336
syncLog(

0 commit comments

Comments
 (0)