Better logging

Author: tejasd

firebase-perf/src/main/java/com/google/firebase/perf/session/PerfSession.java

@@ -20,9 +20,13 @@
 import androidx.annotation.Nullable;
 import androidx.annotation.VisibleForTesting;
 import com.google.firebase.perf.config.ConfigResolver;
+import com.google.firebase.perf.logging.AndroidLogger;
 import com.google.firebase.perf.util.Clock;
 import com.google.firebase.perf.util.Timer;
 import com.google.firebase.perf.v1.SessionVerbosity;
+import com.google.firebase.sessions.SessionDetails;
+import com.google.firebase.sessions.api.SessionSubscriber;
+
 import java.util.List;
 import java.util.Objects;
 import java.util.UUID;
@@ -69,7 +73,9 @@ private PerfSession(@NonNull Parcel in) {
   /** Returns the sessionId of the object. */
   public String sessionId() {
     // TODO(b/394127311): Verify edge cases.
-    return Objects.requireNonNull(SessionManagerKt.Companion.getPerfSessionToAqs().get(internalSessionId)).getSessionId();
+    SessionSubscriber.SessionDetails sessionDetails = SessionManagerKt.Companion.getPerfSessionToAqs().get(internalSessionId);
+    AndroidLogger.getInstance().debug("AQS for " + this.internalSessionId + " is " + sessionDetails);
+    return Objects.requireNonNull(sessionDetails).getSessionId();
   }
 
   protected String getInternalSessionId() {

firebase-perf/src/main/java/com/google/firebase/perf/session/SessionManager.java

@@ -36,7 +36,7 @@
 
 /** Session manager to generate sessionIDs and broadcast to the application. */
 @Keep // Needed because of b/117526359.
-public class SessionManager extends AppStateUpdateHandler {
+public class SessionManager {
 
   @SuppressLint("StaticFieldLeak")
   private static final SessionManager instance = new SessionManager();
@@ -74,7 +74,6 @@ public SessionManager(
     this.gaugeManager = gaugeManager;
     this.perfSession = perfSession;
     this.appStateMonitor = appStateMonitor;
-    registerForAppState();
   }
 
   /**
@@ -99,34 +98,6 @@ public void setApplicationContext(final Context appContext) {
             });
   }
 
-//  @Override
-//  public void onUpdateAppState(ApplicationProcessState newAppState) {
-//    super.onUpdateAppState(newAppState);
-//
-//    if (appStateMonitor.isColdStart()) {
-//      // We want the Session to remain unchanged if this is a cold start of the app since we already
-//      // update the PerfSession in FirebasePerfProvider#onAttachInfo().
-//      return;
-//    }
-//
-//    if (newAppState == ApplicationProcessState.FOREGROUND) {
-//      // A new foregrounding of app will force a new sessionID generation.
-//      PerfSession session = PerfSession.createWithId(UUID.randomUUID().toString());
-//      updatePerfSession(session);
-//    } else {
-//      // If the session is running for too long, generate a new session and collect gauges as
-//      // necessary.
-//      if (perfSession.isSessionRunningTooLong()) {
-//        PerfSession session = PerfSession.createWithId(UUID.randomUUID().toString());
-//        updatePerfSession(session);
-//      } else {
-//        // For any other state change of the application, modify gauge collection state as
-//        // necessary.
-//        startOrStopCollectingGauges(newAppState);
-//      }
-//    }
-//  }
-
   /**
    * Checks if the current {@link PerfSession} is expired/timed out. If so, stop collecting gauges.
    *