Skip to content

Commit b063ea6

Browse files
authored
Merge branch 'main' into rl.macrobenchmark.fix.2
2 parents 592b3e3 + 1f9e582 commit b063ea6

File tree

3 files changed

+21
-17
lines changed

3 files changed

+21
-17
lines changed

.github/workflows/private-mirror-sync.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ jobs:
1919
fetch-depth: 0
2020
submodules: true
2121
token: ${{ secrets.GOOGLE_OSS_BOT_TOKEN }}
22+
committer: google-oss-bot <[email protected]>
2223
- name: Force push HEAD to private repo main branch
2324
run: |
2425
git remote add mirror https://github.com/FirebasePrivate/firebase-android-sdk.git

ci/fireci/fireciplugins/macrobenchmark/commands.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,11 @@ def ci(pull_request: bool, changed_modules_file: Path, repeat: int):
173173
with open(output_path) as output_file:
174174
output = json.load(output_file)
175175
project_name = 'test-changed' if pull_request else 'test-all'
176-
ftl_dirs = list(filter(lambda x: x['project'] == project_name, output))[0]['successful_runs']
176+
ftl_run = list(filter(lambda x: x['project'] == project_name, output))
177+
if not ftl_run:
178+
logger.warning(f'No output for "{project_name}", ignoring.')
179+
return
180+
ftl_dirs = ftl_run[0]['successful_runs']
177181
ftl_bucket_name = 'fireescape-benchmark-results'
178182

179183
log = ci_utils.ci_log_link()

firebase-perf/firebase-perf.gradle

Lines changed: 15 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -99,44 +99,43 @@ android {
9999
}
100100

101101
dependencies {
102-
annotationProcessor 'com.google.dagger:dagger-compiler:2.27'
102+
annotationProcessor libs.dagger.compiler
103103
compileOnly group: 'org.apache.httpcomponents', name: 'httpclient', version: '4.5.6'
104-
implementation "androidx.annotation:annotation:1.1.0"
104+
implementation libs.androidx.annotation
105105
implementation "androidx.lifecycle:lifecycle-process:2.3.1"
106-
implementation "com.google.android.gms:play-services-tasks:18.0.1"
106+
implementation libs.playservices.tasks
107107
implementation libs.protobuf.java.lite
108108
implementation libs.kotlin.stdlib
109-
implementation 'androidx.annotation:annotation:1.7.0'
110109
implementation 'androidx.appcompat:appcompat:1.2.0'
111110
implementation 'com.google.android.datatransport:transport-api:3.0.0'
112-
implementation 'com.google.dagger:dagger:2.27'
111+
implementation libs.dagger.dagger
113112
api 'com.google.firebase:firebase-annotations:16.2.0'
114113
api 'com.google.firebase:firebase-installations-interop:17.1.0'
115114
api 'com.google.firebase:protolite-well-known-types:18.0.0'
116-
implementation 'com.squareup.okhttp3:okhttp:3.12.1'
115+
implementation libs.okhttp
117116
api("com.google.firebase:firebase-common:21.0.0")
118117
api("com.google.firebase:firebase-common-ktx:21.0.0")
119118
api("com.google.firebase:firebase-components:18.0.0")
120119
api("com.google.firebase:firebase-config:21.5.0")
121120
api("com.google.firebase:firebase-installations:17.2.0")
122121
api("com.google.firebase:firebase-sessions:2.0.0") {
123-
exclude group: 'com.google.firebase', module: 'firebase-common'
124-
exclude group: 'com.google.firebase', module: 'firebase-common-ktx'
125-
exclude group: 'com.google.firebase', module: 'firebase-components'
126-
}
122+
exclude group: 'com.google.firebase', module: 'firebase-common'
123+
exclude group: 'com.google.firebase', module: 'firebase-common-ktx'
124+
exclude group: 'com.google.firebase', module: 'firebase-components'
125+
}
127126
javadocClasspath 'com.google.auto.value:auto-value-annotations:1.6.6'
128127
javadocClasspath libs.findbugs.jsr305
129128
runtimeOnly("com.google.firebase:firebase-datatransport:18.1.8") {
130-
exclude group: 'com.google.firebase', module: 'firebase-common'
131-
exclude group: 'com.google.firebase', module: 'firebase-components'
132-
}
129+
exclude group: 'com.google.firebase', module: 'firebase-common'
130+
exclude group: 'com.google.firebase', module: 'firebase-components'
131+
}
133132
testCompileOnly libs.protobuf.java
134133
testImplementation libs.androidx.test.core
135134
testImplementation libs.truth
136135
testImplementation libs.robolectric
137-
testImplementation 'androidx.test:rules:1.2.0'
138-
testImplementation 'junit:junit:4.12'
136+
testImplementation libs.androidx.test.rules
137+
testImplementation libs.junit
139138
testImplementation libs.mockito.core
140139
testImplementation 'org.mockito:mockito-inline:5.2.0'
141140
testImplementation group: 'org.apache.httpcomponents', name: 'httpclient', version: '4.5.6'
142-
}
141+
}

0 commit comments

Comments
 (0)