Skip to content

Commit b384a7c

Browse files
committed
Update the public API
1 parent c88649e commit b384a7c

File tree

1 file changed

+5
-9
lines changed

1 file changed

+5
-9
lines changed

firebase-crashlytics/src/main/java/com/google/firebase/crashlytics/FirebaseCrashlytics.java

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,7 @@ public static FirebaseCrashlytics getInstance() {
205205
* @param throwable a {@link Throwable} to be recorded as a non-fatal event.
206206
*/
207207
public void recordException(@NonNull Throwable throwable) {
208-
recordException(throwable, Map.of());
208+
core.logException(throwable, Map.of());
209209
}
210210

211211
/**
@@ -218,21 +218,17 @@ public void recordException(@NonNull Throwable throwable) {
218218
* <p>The values of event keys override the values of app level custom keys if they're identical.
219219
*
220220
* @param throwable a {@link Throwable} to be recorded as a non-fatal event.
221-
* @param customKeys a {@link Map<String, String>} containing key value pairs to be associated
222-
* with the non fatal exception, in addition to the app level custom keys.
221+
* @param keysAndValues A dictionary of keys and the values to associate with the non fatal
222+
* exception, in addition to the app level custom keys.
223223
*/
224224
public void recordException(
225-
@NonNull Throwable throwable, @NonNull Map<String, String> customKeys) {
225+
@NonNull Throwable throwable, @NonNull CustomKeysAndValues keysAndValues) {
226226
if (throwable == null) { // Users could call this with null despite the annotation.
227227
Logger.getLogger().w("A null value was passed to recordException. Ignoring.");
228228
return;
229229
}
230230

231-
if (customKeys == null) { // Users could call this with null despite the annotation.
232-
customKeys = Map.of();
233-
}
234-
235-
core.logException(throwable, customKeys);
231+
core.logException(throwable, keysAndValues.keysAndValues);
236232
}
237233

238234
/**

0 commit comments

Comments
 (0)