Skip to content

Commit b748629

Browse files
committed
Review changes
1 parent 143efec commit b748629

File tree

12 files changed

+29
-51
lines changed

12 files changed

+29
-51
lines changed

firebase-vertexai/consumer-rules.pro

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,4 +20,5 @@
2020
# hide the original source file name.
2121
#-renamesourcefileattribute SourceFile
2222

23+
-keep class com.google.firebase.vertexai.type.** { *; }
2324
-keep class com.google.firebase.vertexai.common.** { *; }

firebase-vertexai/src/main/kotlin/com/google/firebase/vertexai/GenerativeModel.kt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,6 @@ import com.google.firebase.vertexai.common.APIController
2424
import com.google.firebase.vertexai.common.CountTokensRequest
2525
import com.google.firebase.vertexai.common.GenerateContentRequest
2626
import com.google.firebase.vertexai.common.HeaderProvider
27-
import com.google.firebase.vertexai.internal.util.toInternal
28-
import com.google.firebase.vertexai.internal.util.toPublic
2927
import com.google.firebase.vertexai.type.Content
3028
import com.google.firebase.vertexai.type.CountTokensResponse
3129
import com.google.firebase.vertexai.type.FinishReason

firebase-vertexai/src/main/kotlin/com/google/firebase/vertexai/common/Exceptions.kt

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -126,3 +126,18 @@ internal class ServiceDisabledException(message: String, cause: Throwable? = nul
126126
/** Catch all case for exceptions not explicitly expected. */
127127
internal class UnknownException(message: String, cause: Throwable? = null) :
128128
FirebaseCommonAIException(message, cause)
129+
130+
internal fun makeMissingCaseException(
131+
source: String,
132+
ordinal: Int
133+
): com.google.firebase.vertexai.type.SerializationException {
134+
return com.google.firebase.vertexai.type.SerializationException(
135+
"""
136+
|Missing case for a $source: $ordinal
137+
|This error indicates that one of the `toInternal` conversions needs updating.
138+
|If you're a developer seeing this exception, please file an issue on our GitHub repo:
139+
|https://github.com/firebase/firebase-android-sdk
140+
"""
141+
.trimMargin()
142+
)
143+
}

firebase-vertexai/src/main/kotlin/com/google/firebase/vertexai/internal/util/conversions.kt

Lines changed: 0 additions & 41 deletions
This file was deleted.

firebase-vertexai/src/main/kotlin/com/google/firebase/vertexai/type/Exceptions.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ package com.google.firebase.vertexai.type
1818

1919
import com.google.firebase.vertexai.FirebaseVertexAI
2020
import com.google.firebase.vertexai.common.FirebaseCommonAIException
21-
import com.google.firebase.vertexai.internal.util.toPublic
2221
import kotlinx.coroutines.TimeoutCancellationException
2322

2423
/** Parent class for any errors that occur from the [FirebaseVertexAI] SDK. */

firebase-vertexai/src/main/kotlin/com/google/firebase/vertexai/type/HarmBlockMethod.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
package com.google.firebase.vertexai.type
1818

19-
import com.google.firebase.vertexai.internal.util.makeMissingCaseException
19+
import com.google.firebase.vertexai.common.makeMissingCaseException
2020
import kotlinx.serialization.SerialName
2121
import kotlinx.serialization.Serializable
2222

firebase-vertexai/src/main/kotlin/com/google/firebase/vertexai/type/HarmBlockThreshold.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
package com.google.firebase.vertexai.type
1818

19-
import com.google.firebase.vertexai.internal.util.makeMissingCaseException
19+
import com.google.firebase.vertexai.common.makeMissingCaseException
2020
import kotlinx.serialization.SerialName
2121
import kotlinx.serialization.Serializable
2222

firebase-vertexai/src/main/kotlin/com/google/firebase/vertexai/type/HarmCategory.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@
1616

1717
package com.google.firebase.vertexai.type
1818

19+
import com.google.firebase.vertexai.common.makeMissingCaseException
1920
import com.google.firebase.vertexai.common.util.FirstOrdinalSerializer
20-
import com.google.firebase.vertexai.internal.util.makeMissingCaseException
2121
import kotlinx.serialization.KSerializer
2222
import kotlinx.serialization.SerialName
2323
import kotlinx.serialization.Serializable

firebase-vertexai/src/main/kotlin/com/google/firebase/vertexai/type/Part.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ package com.google.firebase.vertexai.type
1818

1919
import android.graphics.Bitmap
2020
import android.graphics.BitmapFactory
21-
import com.google.firebase.vertexai.internal.util.BASE_64_FLAGS
2221
import java.io.ByteArrayOutputStream
2322
import kotlinx.serialization.DeserializationStrategy
2423
import kotlinx.serialization.SerialName
@@ -133,6 +132,8 @@ public fun Part.asFileDataOrNull(): FileDataPart? = this as? FileDataPart
133132

134133
internal typealias Base64 = String
135134

135+
internal const val BASE_64_FLAGS = android.util.Base64.NO_WRAP
136+
136137
@Serializable(PartSerializer::class) internal sealed interface InternalPart
137138

138139
internal object PartSerializer :

firebase-vertexai/src/main/kotlin/com/google/firebase/vertexai/type/Type.kt

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,9 @@
1717
package com.google.firebase.vertexai.type
1818

1919
import kotlinx.serialization.Serializable
20+
import kotlinx.serialization.json.Json
21+
import kotlinx.serialization.json.JsonObject
22+
import org.json.JSONObject
2023

2124
internal sealed interface Response
2225

@@ -38,3 +41,7 @@ internal data class GRpcErrorResponse(val error: GRpcError) : Response {
3841
)
3942
}
4043
}
44+
45+
internal fun JSONObject.toInternal() = Json.decodeFromString<JsonObject>(toString())
46+
47+
internal fun JsonObject.toPublic() = JSONObject(toString())

0 commit comments

Comments
 (0)