update according to comments

Author: VinayGuthal

firebase-ai/src/main/kotlin/com/google/firebase/ai/type/GenerateContentResponse.kt

@@ -44,18 +44,6 @@ public class GenerateContentResponse(
     candidates.first().content.parts.filterIsInstance<FunctionCallPart>()
   }
 
-  /**
-   * Convenience field to list all the [CodeExecutionResultPart]s in the response, if they exist.
-   */
-  public val codeExecutionResults: List<CodeExecutionResultPart> by lazy {
-    candidates.first().content.parts.filterIsInstance<CodeExecutionResultPart>()
-  }
-
-  /** Convenience field to list all the [ExecutableCodePart]s in the response, if they exist. */
-  public val executableCodeList: List<ExecutableCodePart> by lazy {
-    candidates.first().content.parts.filterIsInstance<ExecutableCodePart>()
-  }
-
   /**
    * Convenience field representing all the [InlineDataPart]s in the first candidate, if they exist.
    *

firebase-ai/src/main/kotlin/com/google/firebase/ai/type/Outcome.kt

@@ -0,0 +1,49 @@
+package com.google.firebase.ai.type
+
+import com.google.firebase.ai.common.util.FirstOrdinalSerializer
+import kotlinx.serialization.KSerializer
+import kotlinx.serialization.Serializable
+
+/** Represents the result of the code execution */
+public class Outcome private constructor(public val ordinal: Int) {
+
+  @Serializable(Internal.Serializer::class)
+  internal enum class Internal {
+    OUTCOME_UNSPECIFIED,
+    OUTCOME_OK,
+    OUTCOME_FAILED,
+    OUTCOME_DEADLINE_EXCEEDED;
+
+    internal object Serializer : KSerializer<Internal> by FirstOrdinalSerializer(Internal::class)
+
+    internal fun toPublic() =
+      when (this) {
+        OUTCOME_UNSPECIFIED -> Outcome.OUTCOME_UNSPECIFIED
+        OUTCOME_OK -> Outcome.OUTCOME_OK
+        OUTCOME_FAILED -> Outcome.OUTCOME_FAILED
+        OUTCOME_DEADLINE_EXCEEDED -> Outcome.OUTCOME_DEADLINE_EXCEEDED
+      }
+  }
+
+  internal fun toInternal() =
+    when (this) {
+      OUTCOME_UNSPECIFIED -> Internal.OUTCOME_UNSPECIFIED
+      OUTCOME_OK -> Internal.OUTCOME_OK
+      OUTCOME_FAILED -> Internal.OUTCOME_FAILED
+      else -> Internal.OUTCOME_DEADLINE_EXCEEDED
+    }
+  public companion object {
+
+    /** Represents that the code execution outcome is unspecified */
+    @JvmField public val OUTCOME_UNSPECIFIED: Outcome = Outcome(0)
+
+    /** Represents that the code execution succeeded */
+    @JvmField public val OUTCOME_OK: Outcome = Outcome(1)
+
+    /** Represents that the code execution failed */
+    @JvmField public val OUTCOME_FAILED: Outcome = Outcome(2)
+
+    /** Represents that the code execution timed out */
+    @JvmField public val OUTCOME_DEADLINE_EXCEEDED: Outcome = Outcome(3)
+  }
+}

firebase-ai/src/main/kotlin/com/google/firebase/ai/type/Part.kt

@@ -39,14 +39,6 @@ public class TextPart(public val text: String) : Part {
   @Serializable internal data class Internal(val text: String) : InternalPart
 }
 
-/* Represents the result of the code execution */
-public enum class Outcome {
-  OUTCOME_UNSPECIFIED,
-  OUTCOME_OK,
-  OUTCOME_FAILED,
-  OUTCOME_DEADLINE_EXCEEDED
-}
-
 /**
  * Represents the code execution result from the model.
  * @property outcome The result of the execution.
@@ -62,7 +54,7 @@ public class CodeExecutionResultPart(public val outcome: Outcome, public val out
 
     @Serializable
     internal data class CodeExecutionResult(
-      @SerialName("outcome") val outcome: Outcome,
+      @SerialName("outcome") val outcome: Outcome.Internal,
       val output: String
     )
   }
@@ -261,7 +253,7 @@ internal fun Part.toInternal(): InternalPart {
       ExecutableCodePart.Internal(ExecutableCodePart.Internal.ExecutableCode(language, code))
     is CodeExecutionResultPart ->
       CodeExecutionResultPart.Internal(
-        CodeExecutionResultPart.Internal.CodeExecutionResult(outcome, output)
+        CodeExecutionResultPart.Internal.CodeExecutionResult(outcome.toInternal(), output)
       )
     else ->
       throw com.google.firebase.ai.type.SerializationException(
@@ -300,7 +292,7 @@ internal fun InternalPart.toPublic(): Part {
     is ExecutableCodePart.Internal ->
       ExecutableCodePart(executableCode.language, executableCode.code)
     is CodeExecutionResultPart.Internal ->
-      CodeExecutionResultPart(codeExecutionResult.outcome, codeExecutionResult.output)
+      CodeExecutionResultPart(codeExecutionResult.outcome.toPublic(), codeExecutionResult.output)
     else ->
       throw com.google.firebase.ai.type.SerializationException(
         "Unsupported part type \"${javaClass.simpleName}\" provided. This model may not be supported by this SDK."