Skip to content

Commit ba8d92a

Browse files
authored
Merge branch 'main' into rl.plugin.product
2 parents bfc278a + d6f0126 commit ba8d92a

File tree

3 files changed

+6
-17
lines changed

3 files changed

+6
-17
lines changed

.github/workflows/fireperf-e2e.yml

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -21,12 +21,6 @@ jobs:
2121
steps:
2222
- name: Checkout firebase-android-sdk
2323
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
24-
- name: Checkout firebase-android-buildtools
25-
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
26-
with:
27-
repository: FirebasePrivate/firebase-android-buildtools
28-
token: ${{ secrets.OSS_BOT_BUILDTOOLS_CHECKOUT_PAT }}
29-
path: firebase-android-buildtools
3024
- name: Set up JDK 17
3125
uses: actions/setup-java@3a4f6e1af504cf6a31855fa899c6aa5355ba6c12 # v4.7.0
3226
with:
@@ -48,7 +42,6 @@ jobs:
4842
- name: Run fireperf end-to-end tests
4943
run: |
5044
fireci fireperf_e2e_test \
51-
--plugin_repo_dir=firebase-android-buildtools \
5245
--target_environment=${{ matrix.environment }}
5346
- name: Notify developers upon failures
5447
if: ${{ failure() }}

ci/README.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,9 @@ This directory contains tooling used to run Continuous Integration tasks.
44

55
## Prerequisites
66

7-
- Requires python3.9+ and setuptools to be installed.
7+
- Install python `3.9`, ideally using [`pyenv`](https://github.com/pyenv/pyenv).
8+
9+
- Install `setuptools`: `pip3 install --upgrade setuptools`
810

911
## Setup
1012

ci/fireci/fireciplugins/fireperf.py

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -24,25 +24,19 @@
2424
_logger = logging.getLogger('fireci.fireperf')
2525

2626

27-
@click.option(
28-
'--plugin_repo_dir',
29-
help='The location of the fireperf plugin repository.',
30-
required=True,
31-
)
3227
@click.option(
3328
'--target_environment',
3429
type=click.Choice(['prod', 'autopush'], case_sensitive=False),
3530
help='The target environment fireperf is built for.',
3631
required=True,
3732
)
3833
@ci_command()
39-
def fireperf_e2e_test(target_environment, plugin_repo_dir):
34+
def fireperf_e2e_test(target_environment):
4035
"""Run Firebase Performance end-to-end test."""
4136

4237
_logger.info('Building fireperf plugin ...')
43-
with chdir(plugin_repo_dir):
44-
build_plugin_task = ':firebase-performance:perf-plugin:publishToMavenLocal'
45-
gradle.run(build_plugin_task, gradle.P('publishMode', 'SNAPSHOT'))
38+
build_plugin_task = ':firebase-perf-gradle:publishToMavenLocal'
39+
gradle.run(build_plugin_task, gradle.P('publishMode', 'SNAPSHOT'))
4640

4741
version = _find_fireperf_plugin_version()
4842
_logger.info(f'Setting environment variable: FIREBASE_PERF_PLUGIN_VERSION={version} ...')

0 commit comments

Comments
 (0)