Review comments

tejasd · tejasd · commit bf94bf03ca48 · 2025-08-13T15:15:17.000-04:00
diff --git a/firebase-perf/src/test/java/com/google/firebase/perf/session/PerfSessionTest.java b/firebase-perf/src/test/java/com/google/firebase/perf/session/PerfSessionTest.java
@@ -275,6 +275,8 @@ public void testBuildAndSortSwapsLegacySessionAtTopWithNoVerboseSessions() {
     // Verify that after building the proto objects for PerfSessions, the first session in the array
     // of proto objects is *not* a legacy session.
     assertThat(isLegacy(perfSessions[0].getSessionId())).isFalse();
+    assertThat(isLegacy(perfSessions[1].getSessionId())).isTrue();
+    assertThat(isLegacy(perfSessions[0].getSessionId())).isFalse();
   }
 
   @Test

Original file line number	Diff line number	Diff line change
`@@ -275,6 +275,8 @@ public void testBuildAndSortSwapsLegacySessionAtTopWithNoVerboseSessions() {`
`275`	`275`	`// Verify that after building the proto objects for PerfSessions, the first session in the array`
`276`	`276`	`// of proto objects is not a legacy session.`
`277`	`277`	`assertThat(isLegacy(perfSessions[0].getSessionId())).isFalse();`
	`278`	`+ assertThat(isLegacy(perfSessions[1].getSessionId())).isTrue();`
	`279`	`+ assertThat(isLegacy(perfSessions[0].getSessionId())).isFalse();`
`278`	`280`	`}`
`279`	`281`
`280`	`282`	`@Test`