Merge branch 'main' into update-code-annotation

Author: tusharkhandelwal8

firebase-config/firebase-config.gradle.kts

@@ -85,6 +85,7 @@ dependencies {
   annotationProcessor(libs.autovalue)
   javadocClasspath(libs.autovalue.annotations)
   compileOnly(libs.autovalue.annotations)
+  compileOnly(libs.errorprone.annotations)
   compileOnly(libs.findbugs.jsr305)
 
   // Testing

firebase-config/src/main/java/com/google/firebase/remoteconfig/internal/ConfigAutoFetch.java

@@ -37,6 +37,7 @@
 import java.util.Random;
 import java.util.Set;
 import java.util.concurrent.ScheduledExecutorService;
+import java.util.concurrent.ScheduledFuture;
 import java.util.concurrent.TimeUnit;
 import org.json.JSONException;
 import org.json.JSONObject;
@@ -248,15 +249,16 @@ private void autoFetch(int remainingAttempts, long targetVersion) {
 
     // Randomize fetch to occur between 0 - 4 seconds.
     int timeTillFetch = random.nextInt(4);
-    scheduledExecutorService.schedule(
-        new Runnable() {
-          @Override
-          public void run() {
-            fetchLatestConfig(remainingAttempts, targetVersion);
-          }
-        },
-        timeTillFetch,
-        TimeUnit.SECONDS);
+    ScheduledFuture<?> unused =
+        scheduledExecutorService.schedule(
+            new Runnable() {
+              @Override
+              public void run() {
+                Task<Void> unused = fetchLatestConfig(remainingAttempts, targetVersion);
+              }
+            },
+            timeTillFetch,
+            TimeUnit.SECONDS);
   }
 
   @VisibleForTesting

firebase-config/src/main/java/com/google/firebase/remoteconfig/internal/ConfigContainer.java

@@ -14,6 +14,7 @@
 
 package com.google.firebase.remoteconfig.internal;
 
+import com.google.errorprone.annotations.CanIgnoreReturnValue;
 import java.util.Date;
 import java.util.HashMap;
 import java.util.HashSet;
@@ -328,11 +329,13 @@ public Builder(ConfigContainer otherContainer) {
       this.builderRolloutMetadata = otherContainer.getRolloutMetadata();
     }
 
+    @CanIgnoreReturnValue
     public Builder replaceConfigsWith(Map<String, String> configsMap) {
       this.builderConfigsJson = new JSONObject(configsMap);
       return this;
     }
 
+    @CanIgnoreReturnValue
     public Builder replaceConfigsWith(JSONObject configsJson) {
       try {
         this.builderConfigsJson = new JSONObject(configsJson.toString());
@@ -345,11 +348,13 @@ public Builder replaceConfigsWith(JSONObject configsJson) {
       return this;
     }
 
+    @CanIgnoreReturnValue
     public Builder withFetchTime(Date fetchTime) {
       this.builderFetchTime = fetchTime;
       return this;
     }
 
+    @CanIgnoreReturnValue
     public Builder withAbtExperiments(JSONArray abtExperiments) {
       try {
         this.builderAbtExperiments = new JSONArray(abtExperiments.toString());
@@ -362,6 +367,7 @@ public Builder withAbtExperiments(JSONArray abtExperiments) {
       return this;
     }
 
+    @CanIgnoreReturnValue
     public Builder withPersonalizationMetadata(JSONObject personalizationMetadata) {
       try {
         this.builderPersonalizationMetadata = new JSONObject(personalizationMetadata.toString());
@@ -374,11 +380,13 @@ public Builder withPersonalizationMetadata(JSONObject personalizationMetadata) {
       return this;
     }
 
+    @CanIgnoreReturnValue
     public Builder withTemplateVersionNumber(long templateVersionNumber) {
       this.builderTemplateVersionNumber = templateVersionNumber;
       return this;
     }
 
+    @CanIgnoreReturnValue
     public Builder withRolloutMetadata(JSONArray rolloutMetadata) {
       try {
         this.builderRolloutMetadata = new JSONArray(rolloutMetadata.toString());

firebase-config/src/main/java/com/google/firebase/remoteconfig/internal/ConfigRealtimeHttpClient.java

@@ -57,6 +57,7 @@
 import java.util.Random;
 import java.util.Set;
 import java.util.concurrent.ScheduledExecutorService;
+import java.util.concurrent.ScheduledFuture;
 import java.util.concurrent.TimeUnit;
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
@@ -381,15 +382,16 @@ private synchronized void makeRealtimeHttpConnection(long retryMilliseconds) {
 
     if (httpRetriesRemaining > 0) {
       httpRetriesRemaining--;
-      scheduledExecutorService.schedule(
-          new Runnable() {
-            @Override
-            public void run() {
-              beginRealtimeHttpStream();
-            }
-          },
-          retryMilliseconds,
-          TimeUnit.MILLISECONDS);
+      ScheduledFuture<?> unused =
+          scheduledExecutorService.schedule(
+              new Runnable() {
+                @Override
+                public void run() {
+                  beginRealtimeHttpStream();
+                }
+              },
+              retryMilliseconds,
+              TimeUnit.MILLISECONDS);
     } else if (!isInBackground) {
       propagateErrors(
           new FirebaseRemoteConfigClientException(