Remove file based memory reading test

Author: tejasd

firebase-perf/src/main/java/com/google/firebase/perf/session/gauges/GaugeMetadataManager.java

@@ -22,11 +22,6 @@
 import com.google.firebase.perf.util.StorageUnit;
 import com.google.firebase.perf.util.Utils;
 import com.google.firebase.perf.v1.GaugeMetadata;
-import java.io.BufferedReader;
-import java.io.FileReader;
-import java.io.IOException;
-import java.util.regex.Matcher;
-import java.util.regex.Pattern;
 
 /**
  * The {@code GaugeMetadataManager} class is responsible for collecting {@link GaugeMetadata}
@@ -73,23 +68,4 @@ public int getMaxEncouragedAppJavaHeapMemoryKb() {
   public int getDeviceRamSizeKb() {
     return Utils.saturatedIntCast(StorageUnit.BYTES.toKilobytes(memoryInfo.totalMem));
   }
-
-  /** Returns the total ram size of the device (in kilobytes) by reading the "proc/meminfo" file. */
-  @VisibleForTesting
-  int readTotalRAM(String procFileName) {
-    try (BufferedReader br = new BufferedReader(new FileReader(procFileName))) {
-      for (String s = br.readLine(); s != null; s = br.readLine()) {
-        if (s.startsWith("MemTotal")) {
-          Matcher m = Pattern.compile("\\d+").matcher(s);
-          return m.find() ? Integer.parseInt(m.group()) : 0;
-        }
-      }
-    } catch (IOException ioe) {
-      logger.warn("Unable to read '" + procFileName + "' file: " + ioe.getMessage());
-    } catch (NumberFormatException nfe) {
-      logger.warn("Unable to parse '" + procFileName + "' file: " + nfe.getMessage());
-    }
-
-    return 0;
-  }
 }

firebase-perf/src/test/java/com/google/firebase/perf/session/gauges/GaugeMetadataManagerTest.java

@@ -15,26 +15,20 @@
 package com.google.firebase.perf.session.gauges;
 
 import static com.google.common.truth.Truth.assertThat;
-import static java.nio.charset.StandardCharsets.UTF_8;
 import static org.mockito.MockitoAnnotations.initMocks;
 import static org.robolectric.Shadows.shadowOf;
 
 import android.app.ActivityManager;
 import android.content.Context;
-import android.os.Environment;
 import androidx.test.core.app.ApplicationProvider;
 import com.google.firebase.perf.FirebasePerformanceTestBase;
 import com.google.firebase.perf.util.StorageUnit;
-import java.io.File;
 import java.io.IOException;
-import java.io.Writer;
-import java.nio.file.Files;
 import org.junit.Before;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 import org.mockito.Mock;
 import org.robolectric.RobolectricTestRunner;
-import org.robolectric.shadows.ShadowEnvironment;
 
 /** Unit tests for {@link com.google.firebase.perf.session.gauges.GaugeMetadataManager} */
 @RunWith(RobolectricTestRunner.class)
@@ -49,12 +43,11 @@ public class GaugeMetadataManagerTest extends FirebasePerformanceTestBase {
 
   @Mock private Runtime runtime;
   private ActivityManager activityManager;
-  private Context appContext;
 
   @Before
   public void setUp() {
     initMocks(this);
-    appContext = ApplicationProvider.getApplicationContext();
+    Context appContext = ApplicationProvider.getApplicationContext();
     activityManager = (ActivityManager) appContext.getSystemService(Context.ACTIVITY_SERVICE);
 
     mockMemory();
@@ -90,62 +83,5 @@ public void testGetDeviceRamSize_returnsExpectedValue() throws IOException {
     int ramSize = testGaugeMetadataManager.getDeviceRamSizeKb();
 
     assertThat(ramSize).isEqualTo(StorageUnit.BYTES.toKilobytes(DEVICE_RAM_SIZE_BYTES));
-    assertThat(ramSize).isEqualTo(testGaugeMetadataManager.readTotalRAM(createFakeMemInfoFile()));
   }
-
-  /** @return The file path of this fake file which can be used to read the file. */
-  private String createFakeMemInfoFile() throws IOException {
-    // Due to file permission issues on forge, it's easiest to just write this file to the emulated
-    // robolectric external storage.
-    ShadowEnvironment.setExternalStorageState(Environment.MEDIA_MOUNTED);
-
-    File file = new File(Environment.getExternalStorageDirectory(), "FakeProcMemInfoFile");
-    Writer fileWriter;
-
-    fileWriter = Files.newBufferedWriter(file.toPath(), UTF_8);
-    fileWriter.write(MEM_INFO_CONTENTS);
-    fileWriter.close();
-
-    return file.getAbsolutePath();
-  }
-
-  private static final String MEM_INFO_CONTENTS =
-      "MemTotal:        "
-          + DEVICE_RAM_SIZE_KB
-          + " kB\n"
-          + "MemFree:          542404 kB\n"
-          + "MemAvailable:    1392324 kB\n"
-          + "Buffers:           64292 kB\n"
-          + "Cached:           826180 kB\n"
-          + "SwapCached:         4196 kB\n"
-          + "Active:           934768 kB\n"
-          + "Inactive:         743812 kB\n"
-          + "Active(anon):     582132 kB\n"
-          + "Inactive(anon):   241500 kB\n"
-          + "Active(file):     352636 kB\n"
-          + "Inactive(file):   502312 kB\n"
-          + "Unevictable:        5148 kB\n"
-          + "Mlocked:             256 kB\n"
-          + "SwapTotal:        524284 kB\n"
-          + "SwapFree:         484800 kB\n"
-          + "Dirty:                 4 kB\n"
-          + "Writeback:             0 kB\n"
-          + "AnonPages:        789404 kB\n"
-          + "Mapped:           241928 kB\n"
-          + "Shmem:             30632 kB\n"
-          + "Slab:             122320 kB\n"
-          + "SReclaimable:      42552 kB\n"
-          + "SUnreclaim:        79768 kB\n"
-          + "KernelStack:       22816 kB\n"
-          + "PageTables:        35344 kB\n"
-          + "NFS_Unstable:          0 kB\n"
-          + "Bounce:                0 kB\n"
-          + "WritebackTmp:          0 kB\n"
-          + "CommitLimit:     2042280 kB\n"
-          + "Committed_AS:   76623352 kB\n"
-          + "VmallocTotal:   251658176 kB\n"
-          + "VmallocUsed:      232060 kB\n"
-          + "VmallocChunk:   251347444 kB\n"
-          + "NvMapMemFree:      48640 kB\n"
-          + "NvMapMemUsed:     471460 kB\n";
 }