Skip to content

Commit cc0c6b5

Browse files
committed
Use better matchers for Make(Un)ReleaseNotesTests
1 parent 4f72bd1 commit cc0c6b5

File tree

2 files changed

+4
-7
lines changed

2 files changed

+4
-7
lines changed

plugins/src/test/kotlin/com/google/firebase/gradle/plugins/MakeReleaseNotesTests.kt

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,8 @@
1717
package com.google.firebase.gradle.plugins
1818

1919
import io.kotest.core.spec.style.FunSpec
20-
import io.kotest.matchers.collections.beEmpty
21-
import io.kotest.matchers.file.exist
22-
import io.kotest.matchers.should
20+
import io.kotest.matchers.file.shouldExist
21+
import io.kotest.matchers.shouldBe
2322
import java.io.File
2423
import org.gradle.testkit.runner.GradleRunner
2524
import org.junit.BeforeClass
@@ -39,9 +38,8 @@ class MakeReleaseNotesTests : FunSpec() {
3938
"firebase-storage/build/tmp/makeReleaseNotes/release_notes.md"
4039
)
4140

42-
releaseNoteFile should exist()
43-
44-
releaseNoteFile.readLines() diff expectedReleaseNoteFile.readLines() should beEmpty()
41+
releaseNoteFile.shouldExist()
42+
releaseNoteFile.readText() shouldBe expectedReleaseNoteFile.readText()
4543
}
4644

4745
private fun buildReleaseNotes() =

plugins/src/test/kotlin/com/google/firebase/gradle/plugins/MoveUnreleasedChangesTests.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ import io.kotest.matchers.collections.shouldContainExactly
2222
import io.kotest.matchers.collections.shouldHaveAtLeastSize
2323
import io.kotest.matchers.collections.shouldHaveSize
2424
import io.kotest.matchers.shouldBe
25-
import io.kotest.matchers.string.shouldMatch
2625
import java.io.File
2726
import org.gradle.testkit.runner.GradleRunner
2827
import org.junit.BeforeClass

0 commit comments

Comments
 (0)