Minor refactoring and renaming changes.

Author: tusharkhandelwal8

firebase-config/src/main/java/com/google/firebase/remoteconfig/internal/ConfigAutoFetch.java

@@ -89,8 +89,8 @@ private synchronized boolean isEventListenersEmpty() {
     return this.eventListeners.isEmpty();
   }
 
-  public void setBackgroundState(boolean backgroundState) {
-    isInBackground = backgroundState;
+  public void setIsInBackground(boolean isInBackground) {
+    this.isInBackground = isInBackground;
   }
 
   private String parseAndValidateConfigUpdateMessage(String message) {

firebase-config/src/main/java/com/google/firebase/remoteconfig/internal/ConfigRealtimeHandler.java

@@ -91,7 +91,7 @@ public synchronized ConfigUpdateListenerRegistration addRealtimeConfigUpdateList
   }
 
   public synchronized void setBackgroundState(boolean isInBackground) {
-    configRealtimeHttpClient.setRealtimeBackgroundState(isInBackground);
+    configRealtimeHttpClient.setIsInBackground(isInBackground);
     if (!isInBackground) {
       beginRealtime();
     }

firebase-config/src/main/java/com/google/firebase/remoteconfig/internal/ConfigRealtimeHttpClient.java

@@ -115,6 +115,7 @@ public class ConfigRealtimeHttpClient {
   private final Random random;
   private final Clock clock;
   private final ConfigSharedPrefsClient sharedPrefsClient;
+  private final Object backgroundLock;
 
   public ConfigRealtimeHttpClient(
       FirebaseApp firebaseApp,
@@ -149,6 +150,7 @@ public ConfigRealtimeHttpClient(
     this.sharedPrefsClient = sharedPrefsClient;
     this.isRealtimeDisabled = false;
     this.isInBackground = false;
+    this.backgroundLock = new Object();
   }
 
   private static String extractProjectNumberFromAppId(String gmpAppId) {
@@ -395,22 +397,20 @@ public void run() {
     }
   }
 
-  public void setRealtimeBackgroundState(boolean backgroundState) {
+  public void setIsInBackground(boolean isInBackground) {
     // Make changes in synchronized block so only one thread sets the background state and calls
     // disconnect.
-    synchronized (isInBackground) {
-      isInBackground = backgroundState;
+    synchronized (backgroundLock) {
+      this.isInBackground = isInBackground;
 
       // Propagate to ConfigAutoFetch as well.
       if (configAutoFetch != null) {
-        configAutoFetch.setBackgroundState(backgroundState);
+        configAutoFetch.setIsInBackground(isInBackground);
       }
-      // Close the connection if the app is in the background and their is an active
+      // Close the connection if the app is in the background and there is an active
       // HttpUrlConnection.
-      if (isInBackground) {
-        if (httpURLConnection != null) {
-          httpURLConnection.disconnect();
-        }
+      if (isInBackground && httpURLConnection != null) {
+        httpURLConnection.disconnect();
       }
     }
   }

firebase-config/src/test/java/com/google/firebase/remoteconfig/FirebaseRemoteConfigTest.java

@@ -352,7 +352,7 @@ public void onError(@NonNull FirebaseRemoteConfigException error) {
             listeners,
             mockRetryListener,
             scheduledExecutorService);
-    configAutoFetch.setBackgroundState(false);
+    configAutoFetch.setIsInBackground(false);
     realtimeSharedPrefsClient =
         new ConfigSharedPrefsClient(
             context.getSharedPreferences("test_file", Context.MODE_PRIVATE));
@@ -1528,7 +1528,7 @@ public void realtime_stream_listen_backgrounded_disconnects() throws Exception {
         .closeRealtimeHttpConnection(any(InputStream.class), any(InputStream.class));
     when(mockHttpURLConnection.getResponseCode()).thenReturn(200);
     configRealtimeHttpClientSpy.beginRealtimeHttpStream();
-    configRealtimeHttpClientSpy.setRealtimeBackgroundState(true);
+    configRealtimeHttpClientSpy.setIsInBackground(true);
     flushScheduledTasks();
 
     verify(mockHttpURLConnection, times(1)).disconnect();