use OutputStream.use instead of manually closing it in a "finally" block

dconeybe · dconeybe · commit d90a1f58e360 · 2025-08-18T15:32:24.000-04:00
diff --git a/firebase-dataconnect/gradleplugin/plugin/src/main/kotlin/com/google/firebase/dataconnect/gradle/plugin/DataConnectGenerateCodeTask.kt b/firebase-dataconnect/gradleplugin/plugin/src/main/kotlin/com/google/firebase/dataconnect/gradle/plugin/DataConnectGenerateCodeTask.kt
@@ -194,10 +194,9 @@ private fun determineCallingConvention(
         callingConvention,
         logFile.absolutePath
       )
-      val logFileStream = logFile.outputStream()
 
       val exitCode: Int =
-        try {
+        logFile.outputStream().use { logFileStream ->
           execOperations
             .exec { execSpec ->
               execSpec.run {
@@ -212,8 +211,6 @@ private fun determineCallingConvention(
               }
             }
             .exitValue
-        } finally {
-          logFileStream.close()
         }
 
       val callingConventionSupported = exitCode == 0

Original file line number	Diff line number	Diff line change
`@@ -194,10 +194,9 @@ private fun determineCallingConvention(`
`194`	`194`	`callingConvention,`
`195`	`195`	`logFile.absolutePath`
`196`	`196`	`)`
`197`		`- val logFileStream = logFile.outputStream()`
`198`	`197`
`199`	`198`	`val exitCode: Int =`
`200`		`- try {`
	`199`	`+ logFile.outputStream().use { logFileStream ->`
`201`	`200`	`execOperations`
`202`	`201`	`.exec { execSpec ->`
`203`	`202`	`execSpec.run {`
`@@ -212,8 +211,6 @@ private fun determineCallingConvention(`
`212`	`211`	`}`
`213`	`212`	`}`
`214`	`213`	`.exitValue`
`215`		`- } finally {`
`216`		`- logFileStream.close()`
`217`	`214`	`}`
`218`	`215`
`219`	`216`	`val callingConventionSupported = exitCode == 0`