Merge branch 'main' into mrober/datastore-bump

Author: mrober

.github/workflows/dataconnect.yml

@@ -217,10 +217,10 @@ jobs:
           if-no-files-found: warn
           compression-level: 9
 
-      - name: Check test result
+      - name: Verify "Gradle connectedCheck" step was successful
         if: steps.connectedCheck.outcome != 'success'
         run: |
-          echo "Failing the job since the connectedCheck step failed"
+          echo 'Failing because the outcome of the "Gradle connectedCheck" step ("${{ steps.connectedCheck.outcome }}") was not successful'
           exit 1
 
   # Check this yml file with "actionlint": https://github.com/rhysd/actionlint

.github/workflows/metalava-semver-check.yml

@@ -0,0 +1,34 @@
+name: Metalava SemVer Check
+
+on:
+  pull_request:
+
+jobs:
+  semver-check:
+    runs-on: ubuntu-latest
+    permissions:
+      pull-requests: write
+    steps:
+      - name: Checkout main
+        uses: actions/[email protected]
+        with:
+          ref: ${{ github.base_ref }}
+
+      - name: Set up JDK 17
+        uses: actions/[email protected]
+        with:
+          java-version: 17
+          distribution: temurin
+          cache: gradle
+
+      - name: Copy previous api.txt files
+        run: ./gradlew copyApiTxtFile
+
+      - name: Checkout PR
+        uses: actions/[email protected]
+        with:
+          ref: ${{ github.head_ref }}
+          clean: false
+
+      - name: Run Metalava SemVer check
+        run: ./gradlew metalavaSemver

firebase-appdistribution/CHANGELOG.md

@@ -1,5 +1,5 @@
 # Unreleased
-
+* [fixed] Added custom tab support for more browsers [#6692]
 
 # 16.0.0-beta14
 * [changed] Internal improvements to testing on Android 14

firebase-appdistribution/src/main/AndroidManifest.xml

@@ -21,6 +21,12 @@
     <uses-permission android:name="android.permission.REQUEST_INSTALL_PACKAGES" />
     <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" />
 
+    <queries>
+        <intent>
+            <action android:name="android.support.customtabs.action.CustomTabsService" />
+        </intent>
+    </queries>
+
     <application>
         <service
             android:name="com.google.firebase.components.ComponentDiscoveryService"

firebase-appdistribution/src/main/java/com/google/firebase/appdistribution/impl/TesterSignInManager.java

@@ -21,10 +21,10 @@
 import android.app.Activity;
 import android.content.Context;
 import android.content.Intent;
-import android.content.pm.ResolveInfo;
 import android.net.Uri;
 import androidx.annotation.NonNull;
 import androidx.annotation.VisibleForTesting;
+import androidx.browser.customtabs.CustomTabsClient;
 import androidx.browser.customtabs.CustomTabsIntent;
 import com.google.android.gms.tasks.OnFailureListener;
 import com.google.android.gms.tasks.Task;
@@ -36,7 +36,7 @@
 import com.google.firebase.appdistribution.FirebaseAppDistributionException.Status;
 import com.google.firebase.inject.Provider;
 import com.google.firebase.installations.FirebaseInstallationsApi;
-import java.util.List;
+import java.util.Collections;
 import java.util.concurrent.Executor;
 import javax.inject.Inject;
 import javax.inject.Singleton;
@@ -212,10 +212,7 @@ private void openSignInFlowInBrowser(String fid, Activity activity) {
   }
 
   private boolean supportsCustomTabs(Context context) {
-    Intent customTabIntent = new Intent("android.support.customtabs.action.CustomTabsService");
-    customTabIntent.setPackage("com.android.chrome");
-    List<ResolveInfo> resolveInfos =
-        context.getPackageManager().queryIntentServices(customTabIntent, 0);
-    return resolveInfos != null && !resolveInfos.isEmpty();
+    String packageName = CustomTabsClient.getPackageName(context, Collections.emptyList());
+    return packageName != null;
   }
 }

firebase-config/src/main/java/com/google/firebase/remoteconfig/FirebaseRemoteConfig.java

@@ -656,16 +656,17 @@ private Task<Void> setDefaultsWithStringsMapAsync(Map<String, String> defaultsSt
    * Asynchronously changes the custom signals for this {@link FirebaseRemoteConfig} instance.
    *
    * <p>Custom signals are subject to limits on the size of key/value pairs and the total
-   * number of signals. Any calls that exceed these limits will be discarded.
+   * number of signals. Any calls that exceed these limits will be discarded. See <a
+   * href="https://firebase.google.com/docs/remote-config/parameters?template_type=client#custom-signal-limits">Custom
+   * Signal Limits</a>.
    *
    * @param customSignals The custom signals to set for this instance.
-   * <ol>
+   * <ul>
    *   <li>New keys will add new key-value pairs in the custom signals.
    *   <li>Existing keys with new values will update the corresponding signals.
    *   <li>Setting a key's value to {@code null} will remove the associated signal.
-   * </ol>
+   * </ul>
    */
-  // TODO(b/385028620): Add link to documentation about custom signal limits.
   @NonNull
   public Task<Void> setCustomSignals(@NonNull CustomSignals customSignals) {
     return Tasks.call(

firebase-crashlytics-ndk/CHANGELOG.md

@@ -1,5 +1,5 @@
 # Unreleased
-
+* [changed] Updated `firebase-crashlytics` dependency to v19.4.1
 
 # 19.3.0
 * [changed] Updated `firebase-crashlytics` dependency to v19.3.0

firebase-crashlytics/CHANGELOG.md

@@ -1,5 +1,14 @@
 # Unreleased
+* [fixed] Fixed NoSuchMethodError when getting process info on Android 13 [#6720]
 
+# 19.4.1
+* [changed] Updated `firebase-sessions` dependency to v2.0.9
+
+
+## Kotlin
+The Kotlin extensions library transitively includes the updated
+`firebase-crashlytics` library. The Kotlin extensions library has no additional
+updates.
 
 # 19.4.0
 * [feature] Added an overload for `recordException` that allows logging additional custom
@@ -324,10 +333,10 @@ updates.
 
 # 18.2.10
 * [fixed] Fixed a bug that could prevent unhandled exceptions from being
-  propogated to the default handler when the network is unavailable.
+  propagated to the default handler when the network is unavailable.
 * [changed] Internal changes to support on-demand fatal crash reporting for
   Flutter apps.
-* [fixed] Fixed a bug that prevented [crashlytics] from initalizing on some
+* [fixed] Fixed a bug that prevented [crashlytics] from initializing on some
   devices in some cases. (#3269)
 
 

firebase-crashlytics/src/main/java/com/google/firebase/crashlytics/internal/ProcessDetailsProvider.kt

@@ -29,6 +29,8 @@ import com.google.firebase.crashlytics.internal.model.CrashlyticsReport.Session.
  * @hide
  */
 internal object ProcessDetailsProvider {
+  // TODO(mrober): Merge this with [com.google.firebase.sessions.ProcessDetailsProvider].
+
   /** Gets the details for all of this app's running processes. */
   fun getAppProcessDetails(context: Context): List<ProcessDetails> {
     val appUid = context.applicationInfo.uid
@@ -70,7 +72,7 @@ internal object ProcessDetailsProvider {
     processName: String,
     pid: Int = 0,
     importance: Int = 0,
-    isDefaultProcess: Boolean = false
+    isDefaultProcess: Boolean = false,
   ) =
     ProcessDetails.builder()
       .setProcessName(processName)
@@ -81,7 +83,7 @@ internal object ProcessDetailsProvider {
 
   /** Gets the app's current process name. If the API is not available, returns an empty string. */
   private fun getProcessName(): String =
-    if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.TIRAMISU) {
+    if (Build.VERSION.SDK_INT > Build.VERSION_CODES.TIRAMISU) {
       Process.myProcessName()
     } else if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.P) {
       Application.getProcessName() ?: ""

firebase-dataconnect/CHANGELOG.md

@@ -1,5 +1,6 @@
 # Unreleased
-
+* [changed] Changed gRPC proto package to v1 (was v1beta).
+  ([#6729](https://github.com/firebase/firebase-android-sdk/pull/6729))
 
 # 16.0.0-beta04
 * [changed] `FirebaseDataConnect.logLevel` type changed from `LogLevel` to