Remove argument configuration

Author: emilypgoogle

plugins/src/main/java/com/google/firebase/gradle/plugins/DackkaGenerationTask.kt

@@ -19,6 +19,7 @@ package com.google.firebase.gradle.plugins
 import java.io.File
 import javax.inject.Inject
 import org.gradle.api.DefaultTask
+import org.gradle.api.Project
 import org.gradle.api.file.FileCollection
 import org.gradle.api.file.RegularFileProperty
 import org.gradle.api.provider.ListProperty
@@ -98,7 +99,6 @@ data class ExternalDocumentationLink(val packageList: File, val externalLink: St
 abstract class GenerateDocumentationTask
 @Inject
 constructor(private val workerExecutor: WorkerExecutor) : GenerateDocumentationTaskExtension() {
-  @get:Input abstract val kotlindocOnly: Property<Boolean>
 
   @TaskAction
   fun build() {
@@ -122,7 +122,7 @@ constructor(private val workerExecutor: WorkerExecutor) : GenerateDocumentationT
       )
     val annotationsNotToDisplayKotlin = listOf("kotlin.ExtensionFunctionType")
     // A null path disables javadoc generation
-    val javadoc: String? = "android".takeUnless { kotlindocOnly.get() }
+    val javadocPath: String? = "android".takeUnless { publishKotlindocOnly(project) }
     val jsonMap =
       mapOf(
         "moduleName" to "",
@@ -154,7 +154,7 @@ constructor(private val workerExecutor: WorkerExecutor) : GenerateDocumentationT
                 JSONObject(
                     mapOf(
                       "docRootPath" to "/docs/reference/",
-                      "javaDocsPath" to javadoc,
+                      "javaDocsPath" to javadocPath,
                       "kotlinDocsPath" to "kotlin",
                       "projectPath" to "client/${clientName.get()}",
                       "includedHeadTagsPathJava" to
@@ -173,6 +173,14 @@ constructor(private val workerExecutor: WorkerExecutor) : GenerateDocumentationT
     return JSONObject(jsonMap)
   }
 
+  /**
+   * Checks if the [Project] should only release Kotlindocs
+   *
+   * This is done via the [FirebaseLibraryExtension.onlyPublishKotlindoc] property.
+   */
+  private fun publishKotlindocOnly(project: Project) =
+    project.firebaseLibrary.onlyPublishKotlindoc.get()
+
   private fun createExternalLinks(
     packageLists: ListProperty<File>
   ): List<ExternalDocumentationLink> {

plugins/src/main/java/com/google/firebase/gradle/plugins/DackkaPlugin.kt

@@ -123,8 +123,7 @@ abstract class DackkaPlugin : Plugin<Project> {
     // TODO(b/270576405): remove afterEvalutate after fixed
     project.afterEvaluate {
       if (weShouldPublish(this)) {
-        val kdocOnly = publishKotlindocOnly(this)
-        val generateDocumentation = registerGenerateDackkaDocumentationTask(project, kdocOnly)
+        val generateDocumentation = registerGenerateDackkaDocumentationTask(project)
 
         val outputDir = generateDocumentation.flatMap { it.outputDirectory }
 
@@ -154,14 +153,6 @@ abstract class DackkaPlugin : Plugin<Project> {
    */
   private fun weShouldPublish(project: Project) = project.firebaseLibrary.publishJavadoc.get()
 
-  /**
-   * Checks if the [Project] should only release Kotlindocs
-   *
-   * This is done via the [FirebaseLibraryExtension.onlyPublishKotlindoc] property.
-   */
-  private fun publishKotlindocOnly(project: Project) =
-    project.firebaseLibrary.onlyPublishKotlindoc.get()
-
   /**
    * Applies common configuration to the [javadocConfig], that is otherwise not present.
    *
@@ -177,11 +168,9 @@ abstract class DackkaPlugin : Plugin<Project> {
   }
 
   private fun registerGenerateDackkaDocumentationTask(
-    project: Project,
-    kotlindocOnly: Boolean,
+    project: Project
   ): TaskProvider<GenerateDocumentationTask> =
     project.tasks.register<GenerateDocumentationTask>("generateDackkaDocumentation") {
-      this.kotlindocOnly.set(kotlindocOnly)
       with(project.extensions.getByType<LibraryExtension>()) {
         libraryVariants.all {
           if (name == "release") {