Skip to content

Commit ed765f5

Browse files
committed
style
1 parent ed9f56c commit ed765f5

File tree

7 files changed

+35
-42
lines changed

7 files changed

+35
-42
lines changed

firebase-perf/src/main/java/com/google/firebase/perf/FirebasePerfEarly.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,10 @@
2020
import com.google.firebase.StartupTime;
2121
import com.google.firebase.perf.application.AppStateMonitor;
2222
import com.google.firebase.perf.config.ConfigResolver;
23+
import com.google.firebase.perf.logging.AndroidLogger;
2324
import com.google.firebase.perf.metrics.AppStartTrace;
2425
import com.google.firebase.perf.session.SessionManager;
2526
import java.util.concurrent.Executor;
26-
import com.google.firebase.perf.logging.AndroidLogger;
27-
import com.google.firebase.perf.session.SessionManagerKt;
2827

2928
/**
3029
* The Firebase Performance early initialization.

firebase-perf/src/main/java/com/google/firebase/perf/FirebasePerfRegistrar.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,10 +30,8 @@
3030
import com.google.firebase.perf.injection.modules.FirebasePerformanceModule;
3131
import com.google.firebase.platforminfo.LibraryVersionComponent;
3232
import com.google.firebase.remoteconfig.RemoteConfigComponent;
33-
import com.google.firebase.sessions.FirebaseSessions;
3433
import com.google.firebase.sessions.api.FirebaseSessionsDependencies;
3534
import com.google.firebase.sessions.api.SessionSubscriber;
36-
3735
import java.util.Arrays;
3836
import java.util.List;
3937
import java.util.concurrent.Executor;

firebase-perf/src/main/java/com/google/firebase/perf/FirebasePerformance.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@
4444
import com.google.firebase.perf.util.Timer;
4545
import com.google.firebase.remoteconfig.RemoteConfigComponent;
4646
import com.google.firebase.sessions.api.FirebaseSessionsDependencies;
47-
4847
import java.lang.annotation.Retention;
4948
import java.lang.annotation.RetentionPolicy;
5049
import java.net.URL;

firebase-perf/src/main/java/com/google/firebase/perf/session/PerfSession.java

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,7 @@
2424
import com.google.firebase.perf.util.Clock;
2525
import com.google.firebase.perf.util.Timer;
2626
import com.google.firebase.perf.v1.SessionVerbosity;
27-
import com.google.firebase.sessions.SessionDetails;
2827
import com.google.firebase.sessions.api.SessionSubscriber;
29-
3028
import java.util.List;
3129
import java.util.Objects;
3230
import java.util.UUID;
@@ -50,7 +48,8 @@ public static PerfSession createNewSession() {
5048

5149
// Every time a PerfSession is created, it sets the AQS to null. Once an AQS is received,
5250
// SessionManagerKt verifies if this is an active session, and sets the AQS session ID.
53-
// The assumption is that new PerfSessions *should* be limited to either App Start, or through AQS.
51+
// The assumption is that new PerfSessions *should* be limited to either App Start, or through
52+
// AQS.
5453
SessionManagerKt.Companion.getPerfSessionToAqs().put(prunedSessionId, null);
5554

5655
return session;
@@ -73,8 +72,10 @@ private PerfSession(@NonNull Parcel in) {
7372
/** Returns the sessionId of the object. */
7473
public String sessionId() {
7574
// TODO(b/394127311): Verify edge cases.
76-
SessionSubscriber.SessionDetails sessionDetails = SessionManagerKt.Companion.getPerfSessionToAqs().get(internalSessionId);
77-
AndroidLogger.getInstance().debug("AQS for " + this.internalSessionId + " is " + sessionDetails);
75+
SessionSubscriber.SessionDetails sessionDetails =
76+
SessionManagerKt.Companion.getPerfSessionToAqs().get(internalSessionId);
77+
AndroidLogger.getInstance()
78+
.debug("AQS for " + this.internalSessionId + " is " + sessionDetails);
7879
return Objects.requireNonNull(sessionDetails).getSessionId();
7980
}
8081

firebase-perf/src/main/java/com/google/firebase/perf/session/SessionManager.java

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
import androidx.annotation.Keep;
2020
import androidx.annotation.VisibleForTesting;
2121
import com.google.firebase.perf.application.AppStateMonitor;
22-
import com.google.firebase.perf.application.AppStateUpdateHandler;
2322
import com.google.firebase.perf.logging.AndroidLogger;
2423
import com.google.firebase.perf.session.gauges.GaugeManager;
2524
import com.google.firebase.perf.v1.ApplicationProcessState;
@@ -62,10 +61,7 @@ public final PerfSession perfSession() {
6261

6362
private SessionManager() {
6463
// Generate a new sessionID for every cold start.
65-
this(
66-
GaugeManager.getInstance(),
67-
PerfSession.createNewSession(),
68-
AppStateMonitor.getInstance());
64+
this(GaugeManager.getInstance(), PerfSession.createNewSession(), AppStateMonitor.getInstance());
6965
}
7066

7167
@VisibleForTesting
@@ -119,7 +115,8 @@ public void stopGaugeCollectionIfSessionRunningTooLong() {
119115
*/
120116
public void updatePerfSession(PerfSession perfSession) {
121117
// Do not update the perf session if it is the exact same sessionId.
122-
if (Objects.equals(perfSession.getInternalSessionId(), this.perfSession.getInternalSessionId())) {
118+
if (Objects.equals(
119+
perfSession.getInternalSessionId(), this.perfSession.getInternalSessionId())) {
123120
return;
124121
}
125122

Lines changed: 23 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -1,32 +1,33 @@
11
package com.google.firebase.perf.session
22

3-
import com.google.firebase.sessions.api.SessionSubscriber
43
import com.google.firebase.perf.logging.AndroidLogger
4+
import com.google.firebase.sessions.api.SessionSubscriber
55

6+
class SessionManagerKt(val dataCollectionEnabled: Boolean) : SessionSubscriber {
7+
override val isDataCollectionEnabled: Boolean
8+
get() = dataCollectionEnabled
69

7-
class SessionManagerKt(val dataCollectionEnabled: Boolean): SessionSubscriber {
8-
override val isDataCollectionEnabled: Boolean
9-
get() = dataCollectionEnabled
10-
11-
override val sessionSubscriberName: SessionSubscriber.Name
12-
get() = SessionSubscriber.Name.PERFORMANCE
10+
override val sessionSubscriberName: SessionSubscriber.Name
11+
get() = SessionSubscriber.Name.PERFORMANCE
1312

14-
override fun onSessionChanged(sessionDetails: SessionSubscriber.SessionDetails) {
15-
AndroidLogger.getInstance().debug("AQS Session Changed: $sessionDetails")
16-
val currentInternalSessionId = SessionManager.getInstance().perfSession().internalSessionId
13+
override fun onSessionChanged(sessionDetails: SessionSubscriber.SessionDetails) {
14+
AndroidLogger.getInstance().debug("AQS Session Changed: $sessionDetails")
15+
val currentInternalSessionId = SessionManager.getInstance().perfSession().internalSessionId
1716

18-
// There can be situations where a new [PerfSession] was created, but an AQS wasn't
19-
// available (during cold start).
20-
if (perfSessionToAqs[currentInternalSessionId] == null) {
21-
perfSessionToAqs[currentInternalSessionId] = sessionDetails
22-
} else {
23-
val newSession = PerfSession.createNewSession()
24-
SessionManager.getInstance().updatePerfSession(newSession)
25-
perfSessionToAqs[newSession.internalSessionId] = sessionDetails
26-
}
17+
// There can be situations where a new [PerfSession] was created, but an AQS wasn't
18+
// available (during cold start).
19+
if (perfSessionToAqs[currentInternalSessionId] == null) {
20+
perfSessionToAqs[currentInternalSessionId] = sessionDetails
21+
} else {
22+
val newSession = PerfSession.createNewSession()
23+
SessionManager.getInstance().updatePerfSession(newSession)
24+
perfSessionToAqs[newSession.internalSessionId] = sessionDetails
2725
}
26+
}
2827

29-
companion object {
30-
val perfSessionToAqs: MutableMap<String, SessionSubscriber.SessionDetails?> by lazy { mutableMapOf() }
28+
companion object {
29+
val perfSessionToAqs: MutableMap<String, SessionSubscriber.SessionDetails?> by lazy {
30+
mutableMapOf()
3131
}
32-
}
32+
}
33+
}

firebase-perf/src/test/java/com/google/firebase/perf/session/SessionManagerTest.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -225,8 +225,7 @@ public void testOnUpdateAppStateMakesGaugeManagerStopCollectingGaugesWhenSession
225225
forceSessionsFeatureDisabled();
226226

227227
SessionManager testSessionManager =
228-
new SessionManager(
229-
mockGaugeManager, PerfSession.createNewSession(), mockAppStateMonitor);
228+
new SessionManager(mockGaugeManager, PerfSession.createNewSession(), mockAppStateMonitor);
230229
testSessionManager.updatePerfSession(PerfSession.createNewSession());
231230

232231
verify(mockGaugeManager).stopCollectingGauges();
@@ -239,8 +238,7 @@ public void testGaugeMetadataIsFlushedOnlyWhenNewVerboseSessionIsCreated() {
239238
// Start with a non verbose session
240239
forceNonVerboseSession();
241240
SessionManager testSessionManager =
242-
new SessionManager(
243-
mockGaugeManager, PerfSession.createNewSession(), mockAppStateMonitor);
241+
new SessionManager(mockGaugeManager, PerfSession.createNewSession(), mockAppStateMonitor);
244242

245243
verify(mockGaugeManager, times(0))
246244
.logGaugeMetadata(

0 commit comments

Comments
 (0)