Skip to content

Commit efd400c

Browse files
committed
dataconnect.yml: use post_comment_for_job_results.py
1 parent 63fdb92 commit efd400c

File tree

1 file changed

+24
-15
lines changed

1 file changed

+24
-15
lines changed

.github/workflows/dataconnect.yml

Lines changed: 24 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -328,7 +328,13 @@ jobs:
328328
run: pyright --warnings --stats
329329

330330
send-notifications:
331-
needs: [integration-test, actionlint-dataconnect-yml]
331+
needs:
332+
- 'integration-test'
333+
- 'actionlint-dataconnect-yml'
334+
- 'python-ci-unit-tests'
335+
- 'python-ci-lint'
336+
- 'python-ci-format'
337+
- 'python-ci-type-check'
332338
if: always()
333339
permissions:
334340
issues: write
@@ -357,8 +363,8 @@ jobs:
357363
python \
358364
calculate_github_issue_for_commenting.py \
359365
--output-file=github_issue_number.txt \
360-
--github-ref='${{ github.ref }}' \
361366
--github-repository='${{ github.repository }}' \
367+
--github-ref='${{ github.ref }}' \
362368
--github-event-name='${{ github.event_name }}' \
363369
--pr-body-github-issue-key=trksmnkncd_notification_issue \
364370
--github-issue-for-scheduled-run=6857 # https://github.com/firebase/firebase-android-sdk/issues/6857
@@ -372,17 +378,20 @@ jobs:
372378
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
373379
run: |
374380
set -euo pipefail
381+
set -xv
375382
376-
cat >message.txt <<EOF
377-
Result of workflows at ${{ github.sha }}:
378-
- integration-test: ${{ (needs.integration-test.result == 'success' && '✅') || '❌' }} ${{ needs.integration-test.result }}
379-
- actionlint-dataconnect-yml: ${{ (needs.actionlint-dataconnect-yml.result == 'success' && '✅') || '❌' }} ${{ needs.actionlint-dataconnect-yml.result }}
380-
381-
${{ github.event.repository.html_url }}/actions/runs/${{ github.run_id }}
382-
383-
run_id=${{ github.run_id }} run_number=${{ github.run_number }} run_attempt=${{ github.run_attempt }}
384-
EOF
385-
386-
echo "Posting comment on GitHub Issue: https://github.com/firebase/firebase-android-sdk/issues/${{ steps.issue-id.outputs.issue }}"
387-
cat message.txt
388-
gh issue comment ${{ steps.issue-id.outputs.issue }} --body-file message.txt -R ${{ github.repository }}
383+
exec python \
384+
post_comment_for_job_results.py \
385+
--github-issue='${{ steps.issue-id.outputs.issue }}' \
386+
--github-repository='${{ github.repository }}' \
387+
--github-sha='${{ github.sha }}' \
388+
--github-repository-html-url='${{ github.event.repository.html_url }}' \
389+
--github-run-id='${{ github.run_id }}' \
390+
--github-run-number='${{ github.run_number }}' \
391+
--github-run-attempt='${{ github.run_attempt }}' \
392+
'integration-test:${{ needs.integration-test.result }}' \
393+
'actionlint-dataconnect-yml:${{ needs.actionlint-dataconnect-yml.result }}' \
394+
'python-ci-unit-tests:${{ needs.python-ci-unit-tests.result }}' \
395+
'python-ci-lint:${{ needs.python-ci-lint.result }}' \
396+
'python-ci-format:${{ needs.python-ci-format.result }}' \
397+
'python-ci-type-check:${{ needs.python-ci-type-check.result }}' \

0 commit comments

Comments
 (0)