Skip to content

firebase-dataconnect merge into main branch #6290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 673 commits into from
Sep 25, 2024
Merged

firebase-dataconnect merge into main branch #6290

merged 673 commits into from
Sep 25, 2024

Conversation

dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Sep 21, 2024 •
edited
Loading

Includes contributions by @cherylEnkidu

dconeybe added 30 commits May 2, 2024 13:41
@dconeybe
DataConnectBackend.kt: fixed bugs in fromInstrumentationArgument() an…
c1a3a17 
…d added unit tests
@dconeybe
DataConnectSettings.kt: fix default host to firebasedataconnect.googl…
a23fb2f 
…eapis.com (was dataconnect.googleapis.com)
@dconeybe
Use DataConnectBackend.kt in integration tests
068efdf
@dconeybe
DataConnectGrpcClient.kt: add x-goog-request-params header (#559)
a6807e8
@dconeybe
TestDataConnectFactory.kt: force a FirebaseApp to be specified, since…
45d8192 
… tests should never be mucking around with the default app
@dconeybe
TestConnectorFactory.kt: make sure to use the settings from the DataC…
e0b8382 
…onnectBackend
@dconeybe
DataConnectGrpcClient.kt: log the metadata
e9f50dc
@dconeybe
Modify some tests to inherit from DataConnectIntegrationTestBase
34fd4ed
@dconeybe
FirebaseAuthBackend.kt added, and AuthIntegrationTest.kt modified to …
3c04775 
…use it
@dconeybe
refactor emulator directory to more closely match what is generated b…
ae7d61c 
…y `firebase dataconnect init`
@dconeybe
start_postgres_pod.sh: improve the wording regarding local connection…
2cc1c19 
… string
@dconeybe
emulator_noauth.sh: add back -local_connection_string since running t…
e25efeb 
…he cli directly does not appear to pick up the value from .firebaserc
@dconeybe
Fix hardcoded serviceId and location in tests
3e5fcef
@dconeybe
PostsConnector.kt: fix hardcoded serviceId and location
02d2f33
@dconeybe
DataConnectAuth.kt/DataConnectGrpcClient.kt: consistently print scrub…
78d31e2 
…bed access token
@dconeybe
DataConnectGrpcClient.kt: remove the 'Bearer' prefix of the x-firebas…
26c9064 
…e-auth-token header
@dconeybe
Factor out location and serviceId used in tests
e5bf084
@dconeybe
emulator_noauth.sh: explicitly specify 'us-central1' so it's obvious …
d663045 
…when it needs to be changed
@dconeybe
Merge remote-tracking branch 'public/master' into dataconnect
e87d7a8
@dconeybe
delete the firebase-dataconnect demo app, which was mostly useless
8a6b018
@dconeybe
DataConnectSettingsUnitTest.kt: fix expected default host to "firebas…
895fc1c 
…edataconnect.googleapis.com" (was "dataconnect.googleapis.com")
@dconeybe
DataConnectUntypedDataIntegrationTest.kt: add tests for null lists (#560
971bdf1 
)
@dconeybe
Add copyright notice to generated code (b/336814936) (#561)
4c1940a
@dconeybe
generate the code into the 'build' directory
22b111d
@dconeybe
QueryApiProposal.kt removed, since it is no longer needed
f8ecfa5
@dconeybe
Add APL2 license headers to all files (#562)
40d3ac8
@dconeybe
Merge remote-tracking branch 'public/master' into dataconnect
f6e8a75
@dconeybe
Merge remote-tracking branch 'public/master' into dataconnect
ff9a735
@dconeybe
Remove the 'dependsOn' kludge in gradle.kts files
ceb6fab
@dconeybe
Add scripts for releasing a scrubbed version of the firebase-dataconn…
46b98ff 
…ect sdk prior to public announcements at i/o (#563)
daymxn
daymxn reviewed Sep 24, 2024
View reviewed changes
Copy link
Member

@daymxn daymxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Build files look fine to me. Still have pending work that needs @rachelsaunders input here, but otherwise I defer to @rlazo for final approval.

Also, worth looking at the smoke test failure. Those don't usually flake.

@dconeybe
Copy link
Contributor Author

dconeybe commented Sep 24, 2024 •
edited
Loading

@rlazo I may need you to merge this PR for me because it won't let me because the cla presubmit is broken with such a large PR.

@dconeybe
Copy link
Contributor Author

dconeybe commented Sep 25, 2024 •
edited
Loading

Also, worth looking at the smoke test failure. Those don't usually flake.

The most recent failure of the smoke test (at the time of writing) was due to this error:

This project's quota for this operation has been exceeded. [ Exceeded quota for verifying passwords. ]

(http://shortn/_hOLZ5pldH3)

A re-run fixed it.

Also, I've opened 2 PRs to fix flaky tests that I came across: #6290 and #6291. I'll continue to monitor the flaky failures.

rachelsaunders
rachelsaunders requested changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@rachelsaunders rachelsaunders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The info in this changelog gets transformed into release notes displayed in the docs website. So it need to be markdown that renders appropriately. No raw URLs. Proper syntax, like backticks. Start the entry whenever possible with a verb in the past tense. Use proper brand names.

If you have the PR/Issue for each of these (except the "initial release" one), then please add that, too.

Thx!

@dconeybe
Copy link
Contributor Author

@rachelsaunders

The info in this changelog gets transformed into release notes displayed in the docs website. So it need to be markdown that renders appropriately. No raw URLs. Proper syntax, like backticks. Start the entry whenever possible with a verb in the past tense. Use proper brand names.

If you have the PR/Issue for each of these (except the "initial release" one), then please add that, too.

Done. Please take a look at https://github.com/firebase/firebase-android-sdk/blob/dataconnect/firebase-dataconnect/CHANGELOG.md.

Also, do you know what values to specify for name.set and versionName.set in the releaseNotes section of firebase-dataconnect.gradle.kts? The values there are merely guesses on my part.

@rachelsaunders
Copy link
Contributor

@rachelsaunders

The info in this changelog gets transformed into release notes displayed in the docs website. So it need to be markdown that renders appropriately. No raw URLs. Proper syntax, like backticks. Start the entry whenever possible with a verb in the past tense. Use proper brand names.
If you have the PR/Issue for each of these (except the "initial release" one), then please add that, too.

Done. Please take a look at https://github.com/firebase/firebase-android-sdk/blob/dataconnect/firebase-dataconnect/CHANGELOG.md.

Beautiful :-D

Also, do you know what values to specify for name.set and versionName.set in the releaseNotes section of firebase-dataconnect.gradle.kts? The values there are merely guesses on my part.

This would be something that @daymxn or @rlazo can help you with.

@dconeybe dconeybe requested a review from daymxn September 25, 2024 08:36
@rlazo rlazo merged commit a95da3f into main Sep 25, 2024
261 of 263 checks passed
@rlazo rlazo deleted the dataconnect branch September 25, 2024 16:17
emilypgoogle pushed a commit that referenced this pull request Sep 25, 2024
@dconeybe @cherylEnkidu
@rachelsaunders @emilypgoogle
firebase-dataconnect merge into main branch (#6290)
11cbfd3 
Includes contributions by @cherylEnkidu

---------

Co-authored-by: cherylEnkidu <[email protected]>
Co-authored-by: rachelsaunders <[email protected]>
emilypgoogle pushed a commit that referenced this pull request Sep 25, 2024
@dconeybe @cherylEnkidu
@rachelsaunders @emilypgoogle
firebase-dataconnect merge into main branch (#6290)
75e37e3 
Includes contributions by @cherylEnkidu

---------

Co-authored-by: cherylEnkidu <[email protected]>
Co-authored-by: rachelsaunders <[email protected]>
@firebase firebase locked and limited conversation to collaborators Oct 26, 2024
@dconeybe dconeybe restored the dataconnect branch December 12, 2024 18:37
@dconeybe dconeybe deleted the dataconnect branch December 12, 2024 18:38
@dconeybe dconeybe restored the dataconnect branch December 12, 2024 21:34
@dconeybe dconeybe deleted the dataconnect branch December 12, 2024 21:35
@dconeybe
Copy link
Contributor Author

To see a snapshot of the dataconnect branch as it was when it was merged into main see https://github.com/dconeybe/dataconnect-android-sdk

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@rlazo rlazo rlazo approved these changes

@rachelsaunders rachelsaunders rachelsaunders approved these changes

@maneesht maneesht Awaiting requested review from maneesht

@cherylEnkidu cherylEnkidu Awaiting requested review from cherylEnkidu

@aashishpatil-g aashishpatil-g Awaiting requested review from aashishpatil-g

@daymxn daymxn Awaiting requested review from daymxn

Assignees

@dconeybe dconeybe

Labels

main-merge-ack size/XXL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@dconeybe @google-oss-bot @rachelsaunders @rlazo @daymxn @cherylEnkidu