From 619eb3f55ab4669a8883384f5f9c1413c75bd322 Mon Sep 17 00:00:00 2001 From: Denver Coneybeare Date: Mon, 30 Sep 2024 16:47:07 +0000 Subject: [PATCH] dataconnect: fix gradle plugin to gracefully handle schemaExtensionsOutputEnabled not being explicitly specified --- .../dataconnect/gradle/plugin/DataConnectRunEmulatorTask.kt | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/firebase-dataconnect/gradleplugin/plugin/src/main/kotlin/com/google/firebase/dataconnect/gradle/plugin/DataConnectRunEmulatorTask.kt b/firebase-dataconnect/gradleplugin/plugin/src/main/kotlin/com/google/firebase/dataconnect/gradle/plugin/DataConnectRunEmulatorTask.kt index 775421f1afc..04148624e87 100644 --- a/firebase-dataconnect/gradleplugin/plugin/src/main/kotlin/com/google/firebase/dataconnect/gradle/plugin/DataConnectRunEmulatorTask.kt +++ b/firebase-dataconnect/gradleplugin/plugin/src/main/kotlin/com/google/firebase/dataconnect/gradle/plugin/DataConnectRunEmulatorTask.kt @@ -24,6 +24,7 @@ import org.gradle.api.tasks.Input import org.gradle.api.tasks.InputDirectory import org.gradle.api.tasks.InputFile import org.gradle.api.tasks.Internal +import org.gradle.api.tasks.Optional import org.gradle.api.tasks.TaskAction abstract class DataConnectRunEmulatorTask : DefaultTask() { @@ -34,7 +35,7 @@ abstract class DataConnectRunEmulatorTask : DefaultTask() { @get:Input abstract val postgresConnectionUrl: Property - @get:Input abstract val schemaExtensionsOutputEnabled: Property + @get:Optional @get:Input abstract val schemaExtensionsOutputEnabled: Property @get:Internal abstract val buildDirectory: DirectoryProperty @@ -43,7 +44,7 @@ abstract class DataConnectRunEmulatorTask : DefaultTask() { val dataConnectExecutable: File = dataConnectExecutable.get().asFile val configDirectory: File = configDirectory.get().asFile val postgresConnectionUrl: String = postgresConnectionUrl.get() - val schemaExtensionsOutputEnabled: Boolean = schemaExtensionsOutputEnabled.get() + val schemaExtensionsOutputEnabled: Boolean = schemaExtensionsOutputEnabled.orNull ?: false val buildDirectory: File = buildDirectory.get().asFile logger.info("dataConnectExecutable={}", dataConnectExecutable.absolutePath)