Skip to content

Conversation

dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Nov 13, 2024

The update to CLI version 1.7.0 causes com.google.firebase.dataconnect.LocalDate to be used instead of java.util.Date in generated code. As a result, some of the integration tests needed to be fixed to compile and pass as part of this PR.

Copy link
Contributor

github-actions bot commented Nov 13, 2024

Release note changes

No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).

Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_responses.sh should be updated to clone the latest version of the responses: v5.2

Copy link
Contributor

github-actions bot commented Nov 13, 2024

Test Results

   58 files  ±0     58 suites  ±0   2m 4s ⏱️ ±0s
  535 tests ±0    534 ✅ ±0  1 💤 ±0  0 ❌ ±0 
1 070 runs  ±0  1 068 ✅ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit a6afee2. ± Comparison against base commit 848650b.

♻️ This comment has been updated with latest results.

@dconeybe dconeybe merged commit b61a095 into main Nov 13, 2024
36 checks passed
@dconeybe dconeybe deleted the dconeybe/dataconnect/JsonUpdate20241113 branch November 13, 2024 23:30
@firebase firebase locked and limited conversation to collaborators Dec 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants