Skip to content

Update CHANGELOG.md #6647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update CHANGELOG.md #6647

wants to merge 1 commit into from

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Jan 28, 2025

Replace the changed tag with deprecated for the last FDL release

@rlazo
Update CHANGELOG.md
deb86ec 
Replace the changed tag with deprecated for the last FDL release
@github-actions
Copy link
Contributor

github-actions bot commented Jan 28, 2025 •
edited
Loading

Release note changes

The following had changelogs that were modified, but did not have any unreleased entries for release notes to generate from.

Changelogs

firebase-dynamic-links

@github-actions
Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_responses.sh should be updated to clone the latest version of the responses: v5.3

@rlazo rlazo requested a review from thatfiredev January 28, 2025 15:35
@rlazo rlazo enabled auto-merge (squash) January 28, 2025 15:35
@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

No changes between base commit (8567a38) and merge commit (8c719de).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ekI0gi34Md.html

@github-actions
Copy link
Contributor

Test Results

 22 files  + 2   22 suites  +2   42s ⏱️ +30s
115 tests + 2  114 ✅ + 1  1 💤 +1  0 ❌ ±0 
252 runs  +26  250 ✅ +24  2 💤 +2  0 ❌ ±0 

Results for commit deb86ec. ± Comparison against base commit 8567a38.

This pull request removes 113 and adds 115 tests. Note that renamed tests count towards both. 
com.google.firebase.vertexai.GenerativeModelTesting ‑ exception thrown when using invalid location
com.google.firebase.vertexai.GenerativeModelTesting ‑ system calling in request
com.google.firebase.vertexai.SchemaTests ‑ basic schema declaration
com.google.firebase.vertexai.SchemaTests ‑ full schema declaration
com.google.firebase.vertexai.StreamingSnapshotTests ‑ citation parsed correctly
com.google.firebase.vertexai.StreamingSnapshotTests ‑ empty content
com.google.firebase.vertexai.StreamingSnapshotTests ‑ http errors
com.google.firebase.vertexai.StreamingSnapshotTests ‑ image rejected
com.google.firebase.vertexai.StreamingSnapshotTests ‑ invalid api key
com.google.firebase.vertexai.StreamingSnapshotTests ‑ invalid json
…

com.google.firebase.dynamiclinks.DynamicLinkTest ‑ testAndroidParameters_Builder_Constructor
com.google.firebase.dynamiclinks.DynamicLinkTest ‑ testAndroidParameters_Builder_Constructor_PackageName
com.google.firebase.dynamiclinks.DynamicLinkTest ‑ testAndroidParameters_Builder_SetFallbackLink
com.google.firebase.dynamiclinks.DynamicLinkTest ‑ testAndroidParameters_Builder_SetMinimumVersion
com.google.firebase.dynamiclinks.DynamicLinkTest ‑ testBuilder_BuildDynamicLink
com.google.firebase.dynamiclinks.DynamicLinkTest ‑ testBuilder_BuildShortDynamicLink_WithSuffix
com.google.firebase.dynamiclinks.DynamicLinkTest ‑ testBuilder_SetDomainUriPrefix
com.google.firebase.dynamiclinks.DynamicLinkTest ‑ testBuilder_SetDynamicLinkDomain
com.google.firebase.dynamiclinks.DynamicLinkTest ‑ testBuilder_SetLink
com.google.firebase.dynamiclinks.DynamicLinkTest ‑ testBuilder_SetLongLink
…

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

No changes between base commit (8567a38) and merge commit (8c719de).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/S0O0fCfhfp.html

thatfiredev
thatfiredev reviewed Jan 28, 2025
View reviewed changes
firebase-dynamic-links/CHANGELOG.md

# 22.1.0
* [changed] Added deprecation annotations to the public API. See https://firebase.google.com/support/dynamic-links-faq for further context.
* [deprecated] Added deprecation annotations to the public API. See https://firebase.google.com/support/dynamic-links-faq for further context.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rachel used a different text in the internal CL. Do we want to use the same text here for consistency?

@rlazo rlazo disabled auto-merge January 28, 2025 18:08
@rlazo rlazo closed this Jan 28, 2025
@rlazo rlazo mentioned this pull request Jan 28, 2025
Merged
@firebase firebase locked and limited conversation to collaborators Feb 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@thatfiredev thatfiredev thatfiredev left review comments

Assignees

No one assigned

Labels

size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rlazo @google-oss-bot @thatfiredev