Skip to content

Conversation

@davidmotson
Copy link
Collaborator

No description provided.

@davidmotson davidmotson requested a review from rlazo March 25, 2025 00:10
@github-actions
Copy link
Contributor

github-actions bot commented Mar 25, 2025

Javadoc Changes:
--- /home/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/vertexai/type/ImagenInlineImage.html	2025-03-25 18:19:41.893258306 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/vertexai/type/ImagenInlineImage.html	2025-03-25 18:17:12.869849243 +0000
@@ -11,7 +11,7 @@
       <pre>@<a href="/docs/reference/android/com/google/firebase/vertexai/type/PublicPreviewAPI.html">PublicPreviewAPI</a><br>public final class <a href="/docs/reference/android/com/google/firebase/vertexai/type/ImagenInlineImage.html">ImagenInlineImage</a></pre>
     </p>
     <hr>
-    <p>Represents an Imagen-generated image that is returned as inline data.</p>
+    <p>Represents an Imagen-generated image that is contained inline</p>
     <h2>Summary</h2>
     <div class="devsite-table-wrapper">
       <table class="responsive">
@@ -29,14 +29,14 @@
             <td><code>final @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> byte[]</code></td>
             <td>
               <div><code><a href="/docs/reference/android/com/google/firebase/vertexai/type/ImagenInlineImage.html#data()">data</a></code></div>
-              <p>The raw image bytes in JPEG or PNG format, as specified by <code><a href="/docs/reference/android/com/google/firebase/vertexai/type/ImagenInlineImage.html#mimeType()">mimeType</a></code>.</p>
+              <p>Contains the raw bytes of the image</p>
             </td>
           </tr>
           <tr>
             <td><code>final @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/String.html">String</a></code></td>
             <td>
               <div><code><a href="/docs/reference/android/com/google/firebase/vertexai/type/ImagenInlineImage.html#mimeType()">mimeType</a></code></div>
-              <p>The IANA standard MIME type of the image data; either <code>&quot;image/png&quot;</code> or <code>&quot;image/jpeg&quot;</code>; to request a different format, see <code><a href="/docs/reference/android/com/google/firebase/vertexai/type/ImagenGenerationConfig.html#imageFormat()">ImagenGenerationConfig.imageFormat</a></code>.</p>
+              <p>Contains the MIME type of the image (for example, <code>&quot;image/png&quot;</code>)</p>
             </td>
           </tr>
         </tbody>
@@ -69,12 +69,12 @@
       <div class="api-item"><a name="getData()"></a><a name="setData()"></a><a name="getData--"></a><a name="setData--"></a>
         <h3 class="api-name" id="data()">data</h3>
         <pre class="api-signature no-pretty-print">public&nbsp;final&nbsp;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> byte[]&nbsp;<a href="/docs/reference/android/com/google/firebase/vertexai/type/ImagenInlineImage.html#data()">data</a></pre>
-        <p>The raw image bytes in JPEG or PNG format, as specified by <code><a href="/docs/reference/android/com/google/firebase/vertexai/type/ImagenInlineImage.html#mimeType()">mimeType</a></code>.</p>
+        <p>Contains the raw bytes of the image</p>
       </div>
       <div class="api-item"><a name="getMimeType()"></a><a name="setMimeType()"></a><a name="getMimeType--"></a><a name="setMimeType--"></a>
         <h3 class="api-name" id="mimeType()">mimeType</h3>
         <pre class="api-signature no-pretty-print">public&nbsp;final&nbsp;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/String.html">String</a>&nbsp;<a href="/docs/reference/android/com/google/firebase/vertexai/type/ImagenInlineImage.html#mimeType()">mimeType</a></pre>
-        <p>The IANA standard MIME type of the image data; either <code>&quot;image/png&quot;</code> or <code>&quot;image/jpeg&quot;</code>; to request a different format, see <code><a href="/docs/reference/android/com/google/firebase/vertexai/type/ImagenGenerationConfig.html#imageFormat()">ImagenGenerationConfig.imageFormat</a></code>.</p>
+        <p>Contains the MIME type of the image (for example, <code>&quot;image/png&quot;</code>)</p>
       </div>
     </div>
     <div class="list">
--- /home/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/vertexai/type/package-summary.html	2025-03-25 18:19:41.894258302 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/vertexai/type/package-summary.html	2025-03-25 18:17:12.871849234 +0000
@@ -227,7 +227,7 @@
           <tr>
             <td><code><a href="/docs/reference/android/com/google/firebase/vertexai/type/ImagenInlineImage.html">ImagenInlineImage</a></code></td>
             <td>
-              <p>Represents an Imagen-generated image that is returned as inline data.</p>
+              <p>Represents an Imagen-generated image that is contained inline</p>
             </td>
           </tr>
           <tr>
--- /home/runner/diff/original/firebase-kotlindoc/kotlin/com/google/firebase/vertexai/type/ImagenInlineImage.html	2025-03-25 18:19:41.885258339 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/kotlin/com/google/firebase/vertexai/type/ImagenInlineImage.html	2025-03-25 18:17:12.860849283 +0000
@@ -11,7 +11,7 @@
       <pre>@<a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/PublicPreviewAPI.html">PublicPreviewAPI</a><br>class <a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/ImagenInlineImage.html">ImagenInlineImage</a></pre>
     </p>
     <hr>
-    <p>Represents an Imagen-generated image that is returned as inline data.</p>
+    <p>Represents an Imagen-generated image that is contained inline</p>
     <h2>Summary</h2>
     <div class="devsite-table-wrapper">
       <table class="responsive">
@@ -51,14 +51,14 @@
             <td><code><a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-byte-array/index.html">ByteArray</a></code></td>
             <td>
               <div><code><a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/ImagenInlineImage.html#data()">data</a></code></div>
-              <p>The raw image bytes in JPEG or PNG format, as specified by <code><a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/ImagenInlineImage.html#mimeType()">mimeType</a></code>.</p>
+              <p>Contains the raw bytes of the image</p>
             </td>
           </tr>
           <tr>
             <td><code><a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-string/index.html">String</a></code></td>
             <td>
               <div><code><a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/ImagenInlineImage.html#mimeType()">mimeType</a></code></div>
-              <p>The IANA standard MIME type of the image data; either <code>&quot;image/png&quot;</code> or <code>&quot;image/jpeg&quot;</code>; to request a different format, see <code><a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/ImagenGenerationConfig.html#imageFormat()">ImagenGenerationConfig.imageFormat</a></code>.</p>
+              <p>Contains the MIME type of the image (for example, <code>&quot;image/png&quot;</code>)</p>
             </td>
           </tr>
         </tbody>
@@ -77,12 +77,12 @@
       <div class="api-item"><a name="getData()"></a><a name="setData()"></a><a name="getData--"></a><a name="setData--"></a>
         <h3 class="api-name" id="data()">data</h3>
         <pre class="api-signature no-pretty-print">val&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/ImagenInlineImage.html#data()">data</a>:&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-byte-array/index.html">ByteArray</a></pre>
-        <p>The raw image bytes in JPEG or PNG format, as specified by <code><a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/ImagenInlineImage.html#mimeType()">mimeType</a></code>.</p>
+        <p>Contains the raw bytes of the image</p>
       </div>
       <div class="api-item"><a name="getMimeType()"></a><a name="setMimeType()"></a><a name="getMimeType--"></a><a name="setMimeType--"></a>
         <h3 class="api-name" id="mimeType()">mimeType</h3>
         <pre class="api-signature no-pretty-print">val&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/ImagenInlineImage.html#mimeType()">mimeType</a>:&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-string/index.html">String</a></pre>
-        <p>The IANA standard MIME type of the image data; either <code>&quot;image/png&quot;</code> or <code>&quot;image/jpeg&quot;</code>; to request a different format, see <code><a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/ImagenGenerationConfig.html#imageFormat()">ImagenGenerationConfig.imageFormat</a></code>.</p>
+        <p>Contains the MIME type of the image (for example, <code>&quot;image/png&quot;</code>)</p>
       </div>
     </div>
   </body>
--- /home/runner/diff/original/firebase-kotlindoc/kotlin/com/google/firebase/vertexai/type/package-summary.html	2025-03-25 18:19:41.886258335 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/kotlin/com/google/firebase/vertexai/type/package-summary.html	2025-03-25 18:17:12.861849279 +0000
@@ -200,7 +200,7 @@
           <tr>
             <td><code><a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/ImagenInlineImage.html">ImagenInlineImage</a></code></td>
             <td>
-              <p>Represents an Imagen-generated image that is returned as inline data.</p>
+              <p>Represents an Imagen-generated image that is contained inline</p>
             </td>
           </tr>
           <tr>

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@github-actions
Copy link
Contributor

github-actions bot commented Mar 25, 2025

Test Results

 18 files  +  4   18 suites  +4   14s ⏱️ -1s
 86 tests + 63   86 ✅ + 63  0 💤 ±0  0 ❌ ±0 
172 runs  +126  172 ✅ +126  0 💤 ±0  0 ❌ ±0 

Results for commit 32ccbec. ± Comparison against base commit 1cf65b9.

This pull request removes 23 and adds 86 tests. Note that renamed tests count towards both.
com.google.firebase.functions.AppCheckLimitedUseTest ‑ FirebaseFunctions#getHttpsCallable should build callable with FAC settings (when false)
com.google.firebase.functions.AppCheckLimitedUseTest ‑ FirebaseFunctions#getHttpsCallable should build callable with FAC settings (when true)
com.google.firebase.functions.AppCheckLimitedUseTest ‑ FirebaseFunctions#getHttpsCallable should not use limited-use tokens by default
com.google.firebase.functions.AppCheckLimitedUseTest ‑ FirebaseFunctions#getHttpsCallableFromUrl callable with FAC settings (when false)
com.google.firebase.functions.AppCheckLimitedUseTest ‑ FirebaseFunctions#getHttpsCallableFromUrl callable with FAC settings (when true)
com.google.firebase.functions.AppCheckLimitedUseTest ‑ FirebaseFunctions#getHttpsCallableFromUrl should not use limited-use tokens by default
com.google.firebase.functions.FunctionsRegistrarTest ‑ getComponents_publishesLibVersionComponent
com.google.firebase.functions.FunctionsTests ‑ Firebase#functions should delegate to FirebaseFunctions#getInstance(FirebaseApp, region)
com.google.firebase.functions.FunctionsTests ‑ Firebase#functions should delegate to FirebaseFunctions#getInstance(region)
com.google.firebase.functions.FunctionsTests ‑ FirebaseApp#functions should delegate to FirebaseFunctions#getInstance(FirebaseApp)
…
com.google.firebase.vertexai.GenerativeModelTesting ‑ exception thrown when using invalid location
com.google.firebase.vertexai.GenerativeModelTesting ‑ system calling in request
com.google.firebase.vertexai.SchemaTests ‑ basic schema declaration
com.google.firebase.vertexai.SchemaTests ‑ full schema declaration
com.google.firebase.vertexai.SerializationTests ‑ test Candidate serialization as Json
com.google.firebase.vertexai.SerializationTests ‑ test GenerateContentResponse serialization as Json
com.google.firebase.vertexai.SerializationTests ‑ test Schema serialization as Json
com.google.firebase.vertexai.SerializationTests ‑ test countTokensResponse serialization as Json
com.google.firebase.vertexai.SerializationTests ‑ test modalityTokenCount serialization as Json
com.google.firebase.vertexai.VertexAIStreamingSnapshotTests ‑ citation parsed correctly
…

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 25, 2025

Coverage Report 1

Affected Products

No changes between base commit (1cf65b9) and merge commit (b19adb2).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/5JIPX7oyVv.html

@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-dataconnect_api.txt:

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 25, 2025

Size Report 1

Affected Products

  • firebase-vertexai

    TypeBase (1cf65b9)Merge (b19adb2)Diff
    aar579 kB581 kB+1.47 kB (+0.3%)
    apk (aggressive)1.40 MB1.40 MB+1.78 kB (+0.1%)
    apk (release)9.37 MB9.37 MB+1.47 kB (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/JsVLi9t3Ws.html

@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-dataconnect_api.txt:

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

2 similar comments
@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-dataconnect_api.txt:

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-dataconnect_api.txt:

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-dataconnect_api.txt:

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@davidmotson davidmotson enabled auto-merge (squash) March 25, 2025 16:15
@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-dataconnect_api.txt:

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@davidmotson davidmotson merged commit 8a72ed5 into main Mar 25, 2025
30 checks passed
@davidmotson davidmotson deleted the davidmotson.ai_monitoring branch March 25, 2025 18:20
tejasd pushed a commit that referenced this pull request Apr 1, 2025
@firebase firebase locked and limited conversation to collaborators Apr 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants