Skip to content

Conversation

@rlazo
Copy link
Collaborator

@rlazo rlazo commented Mar 25, 2025

The test genStreamError_receivesError is flaky due to timeout issues. Bumping timeout to 10s.

The test `genStreamError_receivesError` is flaky due to timeout
issues. Bumping timeout to 10s.
@rlazo rlazo requested review from davidmotson and daymxn March 25, 2025 16:10
@rlazo rlazo enabled auto-merge (squash) March 25, 2025 16:10
@github-actions
Copy link
Contributor

github-actions bot commented Mar 25, 2025

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 25, 2025

Coverage Report 1

Affected Products

  • firebase-functions

    Overall coverage changed from ? (baa335c) to 24.46% (8f5f544) by ?.

    22 individual files with coverage change

    FilenameBase (baa335c)Merge (8f5f544)Diff
    ContextProvider.kt?0.00%?
    DaggerFunctionsComponent.java?100.00%?
    FirebaseContextProvider.kt?27.78%?
    FirebaseContextProvider_Factory.java?0.00%?
    FirebaseFunctions.kt?24.52%?
    FirebaseFunctionsException.kt?0.00%?
    FirebaseFunctions_Factory.java?0.00%?
    Functions.kt?100.00%?
    FunctionsComponent.kt?100.00%?
    FunctionsComponent_MainModule_Companion_BindProjectIdFactory.java?0.00%?
    FunctionsMultiResourceComponent.kt?100.00%?
    FunctionsMultiResourceComponent_Factory.java?0.00%?
    FunctionsMultiResourceComponent_FirebaseFunctionsFactory_Impl.java?0.00%?
    FunctionsRegistrar.kt?100.00%?
    HttpsCallableContext.kt?0.00%?
    HttpsCallableOptions.kt?55.56%?
    HttpsCallableReference.kt?44.83%?
    HttpsCallableResult.kt?0.00%?
    HttpsCallOptions.kt?52.63%?
    PublisherStream.kt?0.00%?
    Serializer.kt?5.26%?
    StreamResponse.kt?0.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/FLwQlWERCw.html

@github-actions
Copy link
Contributor

github-actions bot commented Mar 25, 2025

Test Results

14 files   -  1 020  14 suites   - 1 020   12s ⏱️ - 34m 19s
23 tests  -  5 848  23 ✅  -  5 826  0 💤  - 22  0 ❌ ±0 
46 runs   - 11 759  46 ✅  - 11 715  0 💤  - 44  0 ❌ ±0 

Results for commit 4b2dc7a. ± Comparison against base commit baa335c.

This pull request removes 5848 tests.
com.google.android.datatransport.cct.CctBackendFactoryTest ‑ create_returnCCTBackend_WhenBackendNameIsCCT
com.google.android.datatransport.cct.CctDestinationTest ‑ cctDestination_shouldOnlySupportProtoAndJson
com.google.android.datatransport.cct.CctDestinationTest ‑ cctDestination_shouldSupportProtoAndJson
com.google.android.datatransport.cct.CctTransportBackendTest ‑ decorate_whenOffline_shouldProperlyPopulateNetworkInfo
com.google.android.datatransport.cct.CctTransportBackendTest ‑ decorate_whenOnline_shouldProperlyPopulateNetworkInfo
com.google.android.datatransport.cct.CctTransportBackendTest ‑ schedule_shouldAddCookieOnPseudonymousIds
com.google.android.datatransport.cct.CctTransportBackendTest ‑ schedule_shouldDropCookieOnMixedPseudonymousIds
com.google.android.datatransport.cct.CctTransportBackendTest ‑ send_CompressedResponseIsUncompressed
com.google.android.datatransport.cct.CctTransportBackendTest ‑ send_whenBackendRedirectsMoreThan5Times_shouldOnlyRedirect4Times
com.google.android.datatransport.cct.CctTransportBackendTest ‑ send_whenBackendRedirects_shouldCorrectlyFollowTheRedirectViaPost
…

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-dataconnect_api.txt:

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 25, 2025

@rlazo rlazo merged commit 1cf65b9 into main Mar 25, 2025
31 of 32 checks passed
@rlazo rlazo deleted the rl.vertex.timeout.test branch March 25, 2025 17:35
tejasd pushed a commit that referenced this pull request Apr 1, 2025
The test `genStreamError_receivesError` is flaky due to timeout issues.
Bumping timeout to 10s.
@firebase firebase locked and limited conversation to collaborators Apr 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants