Skip to content

Commit 0028e79

Browse files
authored
Flaky test handling for .info/connected on Android (#937)
1 parent 612e389 commit 0028e79

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

database/integration_test/src/integration_test.cc

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1275,11 +1275,11 @@ TEST_F(FirebaseDatabaseTest, TestInvalidatingReferencesWhenDeletingApp) {
12751275
TEST_F(FirebaseDatabaseTest, TestInfoConnected) {
12761276
SignIn();
12771277

1278-
// The entire test can be a bit flaky on iOS, as the iOS SDK's
1279-
// .info/connected is not quite perfect.
1280-
#if defined(TARGET_OS_IPHONE) && TARGET_OS_IPHONE
1278+
// The entire test can be a bit flaky on mobile, as the iOS and
1279+
// Android SDKs' .info/connected is not quite perfect.
1280+
#if defined(ANDROID) || (defined(TARGET_OS_IPHONE) && TARGET_OS_IPHONE)
12811281
FLAKY_TEST_SECTION_BEGIN();
1282-
#endif // defined(TARGET_OS_IPHONE) && TARGET_OS_IPHONE
1282+
#endif // defined(ANDROID) || (defined(TARGET_OS_IPHONE) && TARGET_OS_IPHONE)
12831283

12841284
firebase::database::DatabaseReference ref = CreateWorkingPath();
12851285
// Force getting a value so that we are connected to the database.
@@ -1316,9 +1316,9 @@ TEST_F(FirebaseDatabaseTest, TestInfoConnected) {
13161316
EXPECT_EQ(reconnected.result()->value(), true);
13171317
}
13181318

1319-
#if defined(TARGET_OS_IPHONE) && TARGET_OS_IPHONE
1319+
#if defined(ANDROID) || (defined(TARGET_OS_IPHONE) && TARGET_OS_IPHONE)
13201320
FLAKY_TEST_SECTION_END();
1321-
#endif // defined(TARGET_OS_IPHONE) && TARGET_OS_IPHONE
1321+
#endif // defined(ANDROID) || (defined(TARGET_OS_IPHONE) && TARGET_OS_IPHONE)
13221322
}
13231323

13241324
TEST_F(FirebaseDatabaseTest, TestGetReferenceWillNullArgument) {

0 commit comments

Comments
 (0)