Feat: add setdefaulteventparameters for iOS and take in vector

This adds in the iOS setdefaulteventparameters.
Along with that I will make the setdefaulteventparameters and logevent take in
vector for the parameters.

Author: AustinBenoit

analytics/src/analytics_android.cc

@@ -19,6 +19,7 @@
 
 #include <cstdint>
 #include <cstring>
+#include <vector>
 
 #include "analytics/src/analytics_common.h"
 #include "analytics/src/include/firebase/analytics.h"
@@ -520,13 +521,18 @@ void LogEvent(const char* name, const Parameter* parameters,
   });
 }
 
-// Set the default event parametrs.
+// log an event and the associated parameters via a vector.
+void LogEvent(const char* name, const std::vector<Parameter>& parameters) {
+  LogEvent(name, parameters.data(), parameters.size());
+}
+
+// Set the default event parameters.
 void SetDefaultEventParameters(const Parameter* parameters,
                                size_t number_of_parameters) {
   FIREBASE_ASSERT_RETURN_VOID(internal::IsInitialized());
   JNIEnv* env = g_app->GetJNIEnv();
 
-  if (!parameters) {
+  if (!parameters || number_of_parameters == 0) {
     env->CallVoidMethod(
         g_analytics_class_instance,
         analytics::GetMethodId(analytics::kSetDefaultEventParameters), nullptr);
@@ -557,6 +563,11 @@ void SetDefaultEventParameters(const Parameter* parameters,
   }
 }
 
+  // Set the default event parameters
+void SetDefaultEventParameters(const std::vector<Parameter>& parameters) {
+  setDefaultEventParameters(parameters.data(), parameters.size());
+}
+
 /// Initiates on-device conversion measurement given a user email address on iOS
 /// (no-op on Android). On iOS, requires dependency
 /// GoogleAppMeasurementOnDeviceConversion to be linked in, otherwise it is a

analytics/src/analytics_desktop.cc

@@ -310,6 +310,11 @@ void LogEvent(const char* name, const Parameter* parameters,
   // c_event_params if non-null.
 }
 
+// log an event and the associated parameters via a vector.
+void LogEvent(const char* name, const std::vector<Parameter>& parameters) {
+  LogEvent(name, parameters.data(), parameters.size());
+}
+
 // Sets a user property to the given value.
 //
 // Up to 25 user property names are supported. Once set, user property values
@@ -434,6 +439,10 @@ void SetDefaultEventParameters(const Parameter* parameters,
   FIREBASE_ASSERT_RETURN_VOID(internal::IsInitialized());
 }
 
+void SetDefaultEventParameters(const std::vector<Parameter>& parameters) {
+  SetDefaultEventParameters(parameters.data(), parameters.size());
+}
+
 void SetConsent(const std::map<ConsentType, ConsentStatus>& consent_settings) {
   FIREBASE_ASSERT_RETURN_VOID(internal::IsInitialized());
 

analytics/src/analytics_ios.mm

@@ -312,7 +312,38 @@ void LogEvent(const char* name, const Parameter* parameters, size_t number_of_pa
   [FIRAnalytics logEventWithName:@(name) parameters:parameters_dict];
 }
 
-void SetDefaultEventParameters(const Parameter* parameters, size_t number_of_parameters) {  
+// log an event and the associated parameters via a vector.
+void LogEvent(const char* name, const std::vector<Parameter>& parameters) {
+  LogEvent(name, parameters.data(), parameters.size());
+}
+
+// Sets the default event parameter
+void SetDefaultEventParameters(const Parameter* parameters, size_t number_of_parameters) {
+  FIREBASE_ASSERT_RETURN_VOID(internal::IsInitialized());
+
+  if (!parameters || number_of_parameters == 0) {
+    [FIRAnalytics setDefaultEventParameters:nil];
+    return;
+  }
+
+  NSMutableDictionary* parameters_dict =
+      [NSMutableDictionary dictionaryWithCapacity:number_of_parameters];
+  for (size_t i = 0; i < number_of_parameters; ++i) {
+    const Parameter& parameter = parameters[i];
+    NSString* parameter_name = SafeString(parameter.name);
+    if (!AddVariantToDictionary(parameters_dict, parameter_name, parameter.value)) {
+      // A Variant type that couldn't be handled was passed in.
+      LogError("SetDefaultEventParameters(%s): %s is not a valid parameter value type. "
+               "No event was logged.",
+               parameter.name, Variant::TypeName(parameter.value.type()));
+    }
+  }
+  [FIRAnalytics setDefaultEventParameters:parameters_dict];
+}
+
+// Sets the default event parameters via a vector
+void SetDefaultEventParameters(const std::vector<Parameter>& parameters) {
+  SetDefaultEventParameters(parameters.data(), parameters.size());
 }
 
 /// Initiates on-device conversion measurement given a user email address on iOS (no-op on

analytics/src/include/firebase/analytics.h

@@ -476,6 +476,28 @@ void LogEvent(const char* name);
 void LogEvent(const char* name, const Parameter* parameters,
               size_t number_of_parameters);
 
+/// @brief Log an event with associated parameters.
+///
+/// An Event is an important occurrence in your app that you want to
+/// measure.  You can report up to 500 different types of events per app and
+/// you can associate up to 25 unique parameters with each Event type.
+///
+/// Some common events are documented in @ref event_names (%event_names.h),
+/// but you may also choose to specify custom event types that are associated
+/// with your specific app.
+///
+/// @param[in] name Name of the event to log. Should contain 1 to 40
+/// alphanumeric characters or underscores. The name must start with an
+/// alphabetic character. Some event names are reserved. See @ref event_names
+/// (%event_names.h) for the list of reserved event names. The "firebase_"
+/// prefix is reserved and should not be used. Note that event names are
+/// case-sensitive and that logging two events whose names differ only in
+/// case will result in two distinct events.
+/// @param[in] parameters Array of Parameter structures.
+/// @param[in] number_of_parameters Number of elements in the parameters
+/// array.
+void LogEvent(const char* name, const std::vector<Parameter>& parameters);
+
 /// @brief Adds parameters that will be set on every event logged from the SDK.
 ///
 /// Adds parameters that will be set on every event logged from the SDK,
@@ -492,6 +514,19 @@ void LogEvent(const char* name, const Parameter* parameters,
 void SetDefaultEventParameters(const Parameter* parameters,
                                size_t number_of_parameters);
 
+/// @brief Adds parameters that will be set on every event logged from the SDK.
+///
+/// Adds parameters that will be set on every event logged from the SDK,
+/// including automatic ones. The values passed in the parameters bundle will
+/// be added to the map of default event parameters. These parameters persist
+/// across app runs. They are of lower precedence than event parameters, so if
+/// an event parameter and a parameter set using this API have the same name,
+/// the value of the event parameter will be used. The same limitations on event
+/// parameters apply to default event parameters.
+///
+/// @param[in] parameters reference to vector of Parameter structures.
+void SetDefaultEventParameters(const std::vector<Parameter>& parameters);
+
 /// Initiates on-device conversion measurement given a user email address on iOS
 /// and tvOS (no-op on Android). On iOS and tvOS, this method requires the
 /// dependency GoogleAppMeasurementOnDeviceConversion to be linked in,